Skip to content

.NET: Disable Parallelization for WorkflowRunActivityStopTests #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westey-m merged 1 commit into from
Feb 26, 2026
+3 −0
Merged

.NET: Disable Parallelization for WorkflowRunActivityStopTests #4313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dotnet/tests/Microsoft.Agents.AI.Workflows.UnitTests/WorkflowRunActivityStopTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@

namespace Microsoft.Agents.AI.Workflows.UnitTests;

Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a summary comment for the NoParallelizationObservabilityTests class similar to the detailed comment on CosmosDBCollectionFixture that explains why parallelization is disabled. For example, explaining that ActivityListener is a global resource and parallel execution would cause test interference. This would make the purpose of this collection definition clearer to future maintainers.

Suggested change
/// <summary>
/// Test collection for observability-related tests that must not run in parallel.
/// These tests configure an <see cref="ActivityListener"/>, which is a process-wide
/// global resource. Running multiple observability tests in parallel could cause
/// interference between listeners and activities, leading to flaky or incorrect results.
/// </summary>

Copilot uses AI. Check for mistakes.
[CollectionDefinition("ObservabilityTests", DisableParallelization = true)]
public class NoParallelizationObservabilityTests { }
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class NoParallelizationObservabilityTests should be marked as sealed to follow the established pattern in the codebase. The similar CosmosDBCollectionFixture class in the CosmosNoSql tests uses sealed. Collection definition classes are not meant to be inherited from, so marking them as sealed makes this intention explicit and prevents unintended inheritance.

Suggested change
public class NoParallelizationObservabilityTests { }
public sealed class NoParallelizationObservabilityTests { }

Copilot uses AI. Check for mistakes.

/// <summary>
/// Regression test for https://github.com/microsoft/agent-framework/issues/4155
/// Verifies that the workflow_invoke Activity is properly stopped/disposed so it gets exported
Expand Down
Loading