Skip to content

.NET: Address PR comments #4255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westey-m merged 1 commit into from
Feb 25, 2026
Merged

.NET: Address PR comments #4255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/ConsoleAppSamplesValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,12 +832,17 @@ private async Task BuildSampleAsync(string samplePath)

using Process buildProcess = new() { StartInfo = buildInfo };
buildProcess.Start();

// Read both streams asynchronously to avoid deadlocks from filled pipe buffers
Task<string> stdoutTask = buildProcess.StandardOutput.ReadToEndAsync();
Task<string> stderrTask = buildProcess.StandardError.ReadToEndAsync();
await buildProcess.WaitForExitAsync();

Comment on lines +836 to 840
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdoutTask is started but never awaited on the success path. Since buildProcess is disposed at the end of the method, the outstanding read can fault and produce unobserved task exceptions or flaky behavior. Suggest awaiting both stdoutTask and stderrTask unconditionally (e.g., await Task.WhenAll(...)) before exiting the method.

Copilot uses AI. Check for mistakes.
string stderr = await stderrTask;
if (buildProcess.ExitCode != 0)
{
string stderr = await buildProcess.StandardError.ReadToEndAsync();
throw new InvalidOperationException($"Failed to build sample at {samplePath}: {stderr}");
string stdout = await stdoutTask;
throw new InvalidOperationException($"Failed to build sample at {samplePath}:\n{stdout}\n{stderr}");
}

this._outputHelper.WriteLine($"Build completed for {samplePath}.");
Expand Down
9 changes: 7 additions & 2 deletions ...et/tests/Microsoft.Agents.AI.Hosting.AzureFunctions.IntegrationTests/SamplesValidation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,12 +830,17 @@ private async Task BuildSampleAsync(string samplePath)

using Process buildProcess = new() { StartInfo = buildInfo };
buildProcess.Start();

// Read both streams asynchronously to avoid deadlocks from filled pipe buffers
Task<string> stdoutTask = buildProcess.StandardOutput.ReadToEndAsync();
Task<string> stderrTask = buildProcess.StandardError.ReadToEndAsync();
await buildProcess.WaitForExitAsync();

Comment on lines +834 to 838
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdoutTask is started but only awaited on the failure path. On a successful build this method can return (and dispose buildProcess) while stdoutTask is still reading, which can lead to unobserved task exceptions / ObjectDisposedException and flaky runs. Consider awaiting both reads unconditionally (e.g., await Task.WhenAll(stdoutTask, stderrTask) before checking ExitCode, or at least await stdoutTask on success).

Copilot uses AI. Check for mistakes.
string stderr = await stderrTask;
if (buildProcess.ExitCode != 0)
{
string stderr = await buildProcess.StandardError.ReadToEndAsync();
throw new InvalidOperationException($"Failed to build sample at {samplePath}: {stderr}");
string stdout = await stdoutTask;
throw new InvalidOperationException($"Failed to build sample at {samplePath}:\n{stdout}\n{stderr}");
}

this._outputHelper.WriteLine($"Build completed for {samplePath}.");
Expand Down
Loading