Skip to content

Add Additional Properties ADR#4246

Merged
westey-m merged 2 commits intomicrosoft:mainfrom
westey-m:adr-agent-additional-properties
Feb 25, 2026
Merged

Add Additional Properties ADR#4246
westey-m merged 2 commits intomicrosoft:mainfrom
westey-m:adr-agent-additional-properties

Conversation

@westey-m
Copy link
Contributor

Motivation and Context

#2131

Description

  • Add Additional Properties ADR

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings February 25, 2026 12:26
@markwallace-microsoft markwallace-microsoft added the documentation Improvements or additions to documentation label Feb 25, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Architectural Decision Record (ADR) documenting the approach for associating AdditionalProperties-style metadata with agents/sessions in the .NET Agent Framework.

Changes:

  • Introduces ADR 0017 describing options for agent/session metadata via AdditionalPropertiesDictionary.
  • Documents tradeoffs across multiple API shapes (in-type property vs constructor injection vs external wrapper).
  • Captures serialization considerations for session metadata.

Copy link
Member

@rogerbarreto rogerbarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might consider adding as part of the decision adding one sample showing how this can be achieved with the (external wrapper) and potentially adding the sample as part of this PR.

@westey-m
Copy link
Contributor Author

We might consider adding as part of the decision adding one sample showing how this can be achieved with the (external wrapper) and potentially adding the sample as part of this PR.

Let's perhaps see if people struggle with this concept first. Any sample we create around this would be very contrived, so I'd rather avoid adding something like it unless we have a clear signal.

@westey-m westey-m enabled auto-merge February 25, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants