Skip to content

.NET Workflows - Add unit tests for QuestionExecutor #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crickman merged 10 commits into from
Feb 17, 2026
Merged

.NET Workflows - Add unit tests for QuestionExecutor #3892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a59eff9
Initial plan
Copilot Feb 12, 2026
f9c785b
Add comprehensive unit tests for QuestionExecutor
Copilot Feb 12, 2026
93ed85b
Address code review feedback and add additional test for default valu…
Copilot Feb 12, 2026
9927845
Checkpoint
crickman Feb 16, 2026
b4826b1
Merge branch 'main' into copilot/add-unit-test-class-for-questionexec…
crickman Feb 16, 2026
4dd3885
Merge branch 'copilot/add-unit-test-class-for-questionexecutor' of ht…
crickman Feb 16, 2026
4149d4c
Polished
crickman Feb 16, 2026
dda3b17
Merge branch 'main' into copilot/add-unit-test-class-for-questionexec…
crickman Feb 17, 2026
fcd3119
Merge branch 'main' into copilot/add-unit-test-class-for-questionexec…
crickman Feb 17, 2026
678ee2d
Merge branch 'main' into copilot/add-unit-test-class-for-questionexec…
crickman Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/QuestionExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,17 @@ public static bool IsComplete(object? message)
await this._promptCount.WriteAsync(context, 0).ConfigureAwait(false);

InitializablePropertyPath variable = Throw.IfNull(this.Model.Variable);
bool hasValue = context.ReadState(variable.Path) is BlankValue;
bool alwaysPrompt = this.Evaluator.GetValue(this.Model.AlwaysPrompt).Value;
bool isValueUndefined = context.ReadState(variable.Path) is BlankValue;
bool proceed = this.Evaluator.GetValue(this.Model.AlwaysPrompt).Value;

bool proceed = !alwaysPrompt || hasValue;
if (proceed)
if (!proceed)
{
SkipQuestionMode mode = this.Evaluator.GetValue(this.Model.SkipQuestionMode).Value;
proceed =
mode switch
{
SkipQuestionMode.SkipOnFirstExecutionIfVariableHasValue => !await this._hasExecuted.ReadAsync(context).ConfigureAwait(false),
SkipQuestionMode.AlwaysSkipIfVariableHasValue => hasValue,
SkipQuestionMode.SkipOnFirstExecutionIfVariableHasValue => isValueUndefined && !await this._hasExecuted.ReadAsync(context).ConfigureAwait(false),
SkipQuestionMode.AlwaysSkipIfVariableHasValue => isValueUndefined,
SkipQuestionMode.AlwaysAsk => true,
_ => true,
};
Expand Down Expand Up @@ -86,7 +85,7 @@ public async ValueTask CaptureResponseAsync(IWorkflowContext context, ExternalIn
FormulaValue? extractedValue = null;
if (!response.HasMessages)
{
string unrecognizedResponse = this.FormatPrompt(this.Model.UnrecognizedPrompt);
string unrecognizedResponse = this.Model.UnrecognizedPrompt is not null ? this.FormatPrompt(this.Model.UnrecognizedPrompt) : "Invalid response";
await context.AddEventAsync(new MessageActivityEvent(unrecognizedResponse.Trim()), cancellationToken).ConfigureAwait(false);
}
else
Expand Down Expand Up @@ -128,7 +127,7 @@ public async ValueTask CaptureResponseAsync(IWorkflowContext context, ExternalIn
}
}

await this.AssignAsync(this.Model.Variable?.Path, extractedValue, context).ConfigureAwait(false);
await this.AssignAsync(Throw.IfNull(this.Model.Variable).Path, extractedValue, context).ConfigureAwait(false);
await this._hasExecuted.WriteAsync(context, true).ConfigureAwait(false);
await context.SendResultMessageAsync(this.Id, cancellationToken).ConfigureAwait(false);
}
Expand All @@ -145,9 +144,13 @@ private async ValueTask PromptAsync(IWorkflowContext context, CancellationToken
int actualCount = await this._promptCount.ReadAsync(context).ConfigureAwait(false);
if (actualCount >= repeatCount)
{
ValueExpression defaultValueExpression = Throw.IfNull(this.Model.DefaultValue);
DataValue defaultValue = this.Evaluator.GetValue(defaultValueExpression).Value;
await this.AssignAsync(this.Model.Variable?.Path, defaultValue.ToFormula(), context).ConfigureAwait(false);
DataValue defaultValue = DataValue.Blank();
if (this.Model.DefaultValue is not null)
{
ValueExpression defaultValueExpression = Throw.IfNull(this.Model.DefaultValue);
defaultValue = this.Evaluator.GetValue(defaultValueExpression).Value;
}
await this.AssignAsync(Throw.IfNull(this.Model.Variable).Path, defaultValue.ToFormula(), context).ConfigureAwait(false);
string defaultValueResponse = this.FormatPrompt(this.Model.DefaultValueResponse);
await context.AddEventAsync(new MessageActivityEvent(defaultValueResponse.Trim()), cancellationToken).ConfigureAwait(false);
await context.SendResultMessageAsync(this.Id, cancellationToken).ConfigureAwait(false);
Expand Down
Loading
Loading