Skip to content

Conversation

@westey-m
Copy link
Contributor

Motivation and Context

Recreating the previous PR #2503 to target the main branch.

Description

  • Adding feature collections ADR

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI review requested due to automatic review settings January 21, 2026 15:34
@markwallace-microsoft markwallace-microsoft added documentation Improvements or additions to documentation .NET labels Jan 21, 2026
@github-actions github-actions bot changed the title Adding feature collections ADR .NET: Adding feature collections ADR Jan 21, 2026
@westey-m westey-m mentioned this pull request Jan 21, 2026
4 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an Architectural Decision Record (ADR) for feature collections and includes references to four other new ADR documents in the solution file. The main ADR (0014-feature-collections.md) documents the decision to use AdditionalProperties dictionaries instead of a dedicated feature collection implementation for passing arbitrary services or data to agents and components in the agent execution stack.

Changes:

  • Added ADR 0014 documenting the feature collections design decision and rationale
  • Added references to ADRs 0010-0014 in the .NET solution file for visibility
  • Included supporting ADRs for Python-specific decisions (get_response simplification and TypedDict options)

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 9 comments.

File Description
dotnet/agent-framework-dotnet.slnx Added references to five new ADR files (0010-0014) in the solution file for better visibility and navigation
docs/decisions/0014-feature-collections.md New ADR documenting the decision to use AdditionalProperties for feature collections, with detailed analysis of alternatives and sample scenarios
docs/decisions/0013-python-get-response-simplification.md New ADR documenting the Python-specific decision to consolidate streaming and non-streaming methods into a single get_response method
docs/decisions/0012-python-typeddict-options.md New ADR documenting the use of TypedDict with generic type parameters for type-safe chat client options in Python

@westey-m westey-m added this pull request to the merge queue Jan 22, 2026
Merged via the queue into microsoft:main with commit 2cf4980 Jan 22, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation .NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants