-
Notifications
You must be signed in to change notification settings - Fork 1k
[BREAKING] Python: Refactor orchestrations #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TaoChenOSU
merged 29 commits into
microsoft:main
from
TaoChenOSU:taochen/python-refactor-groupchat
Jan 13, 2026
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
dbe5ff1
Group chat refactoring Part 1; Next: HIL and handoff
TaoChenOSU 16ae7fe
Add agent approval flow; next samples
TaoChenOSU fc0268c
WIP: samples
TaoChenOSU e46ccf9
Merge branch 'main' into local-branch-python-group-chat-refactoring
TaoChenOSU 3d5b831
WIP: HIL samples
TaoChenOSU 5901421
Group chat HIL working; next: handoff
TaoChenOSU c9e7286
Fix group chat tool approval sample
TaoChenOSU aa5edbf
WIP: refactor handoff; next handoff handling
TaoChenOSU c6e5121
Handoff done; next handoff samples and concurrent and sequential
TaoChenOSU 60fd7f0
Handoff samples, concurrent, and sequential done; next Magentic
TaoChenOSU b555421
WIP: magentic; next test with samples + HIL
TaoChenOSU b808c18
Magentic Working; next fix all samples and tests
TaoChenOSU 36d908c
Fix handoff samples; next tests
TaoChenOSU c4e7c66
WIP: fixing tests; some orchestration as agent samples are failing
TaoChenOSU d9d371e
Group chat unit tests done
TaoChenOSU b2d918e
Handoff unit tests done
TaoChenOSU 9b6a273
Remove old orchestration_request_info and fix related tests
TaoChenOSU a362161
Magentic unit tests done
TaoChenOSU 22d56ca
Fix samples
TaoChenOSU c003804
Merge branch 'main' into local-branch-python-group-chat-refactoring
TaoChenOSU 2d5110c
Fix test
TaoChenOSU 8070a6d
Fix test 2
TaoChenOSU 4540771
mypy
TaoChenOSU b018eab
Address comments
TaoChenOSU 11678e5
Update readme
TaoChenOSU 0cbef2f
Address comments
TaoChenOSU d241065
Address comments 2
TaoChenOSU e7dcaa1
Replace display name
TaoChenOSU ba5befc
Merge branch 'main' into local-branch-python-group-chat-refactoring
TaoChenOSU File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
python/packages/core/agent_framework/_workflows/_agent_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| from .._agents import AgentProtocol | ||
|
|
||
|
|
||
| def resolve_agent_id(agent: AgentProtocol) -> str: | ||
| """Resolve the unique identifier for an agent. | ||
| Prefers the `.name` attribute if set; otherwise falls back to `.id`. | ||
| Args: | ||
| agent: The agent whose identifier is to be resolved. | ||
| Returns: | ||
| The resolved unique identifier for the agent. | ||
| """ | ||
| return agent.name if agent.name else agent.id |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.