Skip to content

.NET: Comment on DevUI middleware redirectUrl #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeagleGross merged 2 commits into from
Dec 11, 2025
Merged

.NET: Comment on DevUI middleware redirectUrl #2723

DeagleGross merged 2 commits into from
Dec 11, 2025

Conversation

@DeagleGross
Copy link
Contributor

@DeagleGross DeagleGross commented Dec 9, 2025

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@DeagleGross DeagleGross self-assigned this Dec 9, 2025
Copilot AI review requested due to automatic review settings December 9, 2025 11:47
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a CodeQL suppression comment to address a security warning (SM04598) related to a redirect URL in the DevUI middleware. The comment provides justification for why the redirect is considered safe.

Key Changes:

  • Added inline CodeQL suppression comment with justification for redirect URL security warning

Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@victordibia victordibia added devui DevUI-related items .NET and removed .NET labels Dec 9, 2025
@DeagleGross DeagleGross added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 5da1c2f Dec 11, 2025
14 checks passed
@crickman crickman deleted the dmkorolev/url-redirect-codeql branch December 11, 2025 16:31
This was referenced Dec 21, 2025
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@rogerbarreto rogerbarreto rogerbarreto approved these changes

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

Assignees

@DeagleGross DeagleGross

Labels

devui DevUI-related items .NET

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DeagleGross @rogerbarreto @markwallace-microsoft @victordibia