Skip to content

Conversation

@crickman
Copy link
Contributor

@crickman crickman commented Dec 8, 2025

Motivation and Context

Noticed a mix of minor clean-up and bug-fix issues as part of exploring a feature update.

Description

  • Removed extraneous project references
  • Fixed typo in DeepResearch.yaml workflow
  • Removed duplicate output
  • Removed solution reference to missing workflow
  • Add missing example workflow to solution

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

@crickman crickman self-assigned this Dec 8, 2025
Copilot AI review requested due to automatic review settings December 8, 2025 20:02
@crickman crickman added bug Something isn't working workflows Related to Workflows in agent-framework samples Issue relates to the samples labels Dec 8, 2025
@crickman crickman moved this to In Review in Agent Framework Dec 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs minor clean-up and bug fixes across the .NET workflow samples, improving code quality and consistency without changing functionality.

  • Fixed a typo in the DeepResearch workflow YAML configuration
  • Added missing console color resets in WorkflowRunner for better terminal output handling
  • Removed extraneous project references from multiple sample projects
  • Removed duplicate workflow completion notification

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workflow-samples/DeepResearch.yaml Fixed typo: changed "inputs:" to "input:" to match the correct InvokeAzureAgent schema
dotnet/src/Shared/Workflows/Execution/WorkflowRunner.cs Added Console.ResetColor() calls after setting console colors to properly restore terminal state
dotnet/samples/GettingStarted/Workflows/_Foundational/08_WriterCriticWorkflow/08_WriterCriticWorkflow.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/_Foundational/07_MixedWorkflowAgentsAndExecutors/07_MixedWorkflowAgentsAndExecutors.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/_Foundational/06_SubWorkflows/06_SubWorkflows.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/_Foundational/05_MultiModelService/05_MultiModelService.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/_Foundational/04_AgentWorkflowPatterns/04_AgentWorkflowPatterns.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/_Foundational/03_AgentsInWorkflows/03_AgentsInWorkflows.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/Observability/WorkflowAsAnAgent/WorkflowAsAnAgentObservability.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/Declarative/ExecuteWorkflow/Program.cs Removed duplicate "Done!" notification (already output by WorkflowRunner)
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/03_MultiSelection/03_MultiSelection.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/02_SwitchCase/02_SwitchCase.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/ConditionalEdges/01_EdgeCondition/01_EdgeCondition.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/Concurrent/Concurrent/Concurrent.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/Agents/WorkflowAsAnAgent/WorkflowAsAnAgent.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/samples/GettingStarted/Workflows/Agents/CustomAgentExecutors/CustomAgentExecutors.csproj Removed unused Microsoft.Agents.AI.AzureAI.Persistent project reference
dotnet/agent-framework-dotnet.slnx Fixed incorrect workflow sample file reference (ConfirmInput.yaml → CustomerSupport.yaml) and reordered Client/Server project pairs for consistency

@crickman crickman added this pull request to the merge queue Dec 8, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 8, 2025
@crickman crickman added this pull request to the merge queue Dec 8, 2025
Merged via the queue into main with commit 1e6aedb Dec 8, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in Agent Framework Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working .NET samples Issue relates to the samples workflows Related to Workflows in agent-framework

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants