-
Notifications
You must be signed in to change notification settings - Fork 942
.NET: [Breaking] Move TextSearchProvider and TextSearchProviderOptions to Microsoft.Agents.AI namespace #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ents.AI namespace Co-authored-by: SergeyMenshykh <[email protected]>
|
@copilot Please revert the exclusion of the AgentWithTextSearchRag project from the solution. The sample will be updated later. |
Co-authored-by: SergeyMenshykh <[email protected]>
dotnet/samples/GettingStarted/AgentWithRAG/AgentWithRAG_Step01_BasicTextRAG/Program.cs
Show resolved
Hide resolved
…mple Co-authored-by: SergeyMenshykh <[email protected]>
…om AgentWithRAG_Step01_BasicTextRAG Co-authored-by: SergeyMenshykh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR relocates TextSearchProvider and TextSearchProviderOptions from the Microsoft.Agents.AI.Data namespace to the parent Microsoft.Agents.AI namespace to improve API organization.
- Moved namespace declaration from
Microsoft.Agents.AI.DatatoMicrosoft.Agents.AIfor both classes - Removed obsolete
using Microsoft.Agents.AI.Data;statements from all affected files
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI/TextSearchProvider.cs | Updated namespace declaration from Microsoft.Agents.AI.Data to Microsoft.Agents.AI |
| dotnet/src/Microsoft.Agents.AI/TextSearchProviderOptions.cs | Updated namespace declaration from Microsoft.Agents.AI.Data to Microsoft.Agents.AI |
| dotnet/src/Microsoft.Agents.AI/AgentJsonUtilities.cs | Removed now-unnecessary using Microsoft.Agents.AI.Data; statement |
| dotnet/tests/Microsoft.Agents.AI.UnitTests/Data/TextSearchProviderTests.cs | Removed now-unnecessary using Microsoft.Agents.AI.Data; statement |
| dotnet/samples/GettingStarted/AgentWithRAG/AgentWithRAG_Step01_BasicTextRAG/Program.cs | Removed now-unnecessary using Microsoft.Agents.AI.Data; statement |
| dotnet/samples/GettingStarted/AgentWithRAG/AgentWithRAG_Step02_CustomVectorStoreRAG/Program.cs | Removed now-unnecessary using Microsoft.Agents.AI.Data; statement |
| dotnet/samples/GettingStarted/AgentWithRAG/AgentWithRAG_Step03_CustomRAGDataSource/Program.cs | Removed now-unnecessary using Microsoft.Agents.AI.Data; statement |
|
Add |
Motivation and Context
Relocates
TextSearchProviderandTextSearchProviderOptionsclasses fromMicrosoft.Agents.AI.Datanamespace toMicrosoft.Agents.AInamespace for better API organization.Description
namespace Microsoft.Agents.AI;instead ofnamespace Microsoft.Agents.AI.Data;Data/subdirectory to parentMicrosoft.Agents.AI/directoryusing Microsoft.Agents.AI.Data;from:AgentJsonUtilities.csTextSearchProviderTests.csNote: Sample files retain the
using Microsoft.Agents.AI.Data;statement and will be updated separately.Before:
After:
Contribution Checklist
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.