.NET: Require thread for background responses #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation to prevent background responses without a thread in A2AAgent, aligning its behavior with ChatClientAgent to ensure consistent user experience.
Key Changes
- Extracted thread validation logic into a new
GetA2AThreadhelper method that validates both the background response requirement and thread type compatibility - Added comprehensive unit tests covering both
RunAsyncandRunStreamingAsyncmethods for the new validation scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.A2A/A2AAgent.cs | Refactored thread validation by introducing GetA2AThread method that enforces thread requirement when AllowBackgroundResponses is enabled and validates thread type compatibility |
| dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/A2AAgentTests.cs | Added four new test methods covering both sync and streaming scenarios for background responses without thread and invalid thread type, plus a helper class for testing invalid thread types |
westey-m
approved these changes
Nov 27, 2025
dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/A2AAgentTests.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/A2AAgentTests.cs
Outdated
Show resolved
Hide resolved
dotnet/tests/Microsoft.Agents.AI.A2A.UnitTests/A2AAgentTests.cs
Outdated
Show resolved
Hide resolved
rogerbarreto
approved these changes
Nov 27, 2025
…hub.com/SergeyMenshykh/agent-framework into require-thread-for-background-responses
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
rogerbarreto
approved these changes
Nov 27, 2025
This was referenced Dec 5, 2025
This was referenced Dec 15, 2025
.NET: Bump Microsoft.Agents.AI.Workflows from 1.0.0-preview.251125.1 to 1.0.0-preview.251219.1
#2997
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the usage of background responses if no agent thread is provided to
A2AAgent.Run{Streaming}Asynccalls. This change aligns the A2A agent's behavior with that of theChatClientAgent, where the absence of a thread with background responses could cause inconsistency issues.