Skip to content

.NET: Use Random.GetString in hosting IdGenerator #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Nov 25, 2025
Merged

.NET: Use Random.GetString in hosting IdGenerator #2427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/IdGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ private static string GetRandomString(int stringLength, Random? random)
const string Chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
if (random is not null)
{
#if NET10_0_OR_GREATER
return random.GetString(Chars, stringLength);
#else
// Use deterministic random generation when seed is provided
return string.Create(stringLength, random, static (destination, random) =>
{
Expand All @@ -154,6 +157,7 @@ private static string GetRandomString(int stringLength, Random? random)
destination[i] = Chars[random.Next(Chars.Length)];
}
});
#endif
}

// Use cryptographically secure random generation when no seed is provided
Expand Down
Loading