.NET: Add unit tests for RetrieveConversationMessagesExecutor #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peibekwe
requested review from
TaoChenOSU,
alliscode,
crickman,
lokitoth and
moonbox3
github-actions
bot
changed the title
crickman
approved these changes
Nov 21, 2025
alliscode
approved these changes
Nov 21, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive unit tests for the RetrieveConversationMessagesExecutor class in the declarative workflow framework. The changes refactor the MockAgentProvider to better support testing of methods that retrieve multiple messages.
Key changes:
- New test file with two test cases covering basic and advanced retrieval scenarios
- Refactored
MockAgentProviderfrom single message to message list support - Updated existing
RetrieveConversationMessageExecutorTestto work with the refactored mock
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RetrieveConversationMessagesExecutorTest.cs | New test class with tests for retrieving conversation messages with and without optional parameters |
| MockAgentProvider.cs | Refactored to use TestMessages list instead of single TestChatMessage, added GetMessagesAsync mock setup and ToAsyncEnumerableAsync helper |
| RetrieveConversationMessageExecutorTest.cs | Updated to retrieve first message from TestMessages list instead of TestChatMessage property |
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/MockAgentProvider.cs
Show resolved
Hide resolved
...s.AI.Workflows.Declarative.UnitTests/ObjectModel/RetrieveConversationMessagesExecutorTest.cs
Show resolved
Hide resolved
This was referenced Dec 5, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
.NET: Bump Microsoft.Agents.AI.Workflows from 1.0.0-preview.251125.1 to 1.0.0-preview.251219.1
#2997
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds unit test around the RetrieveConversationMessagesExecutor executor for declarative workflow. Updated MockAgentProvider as required.
Contribution Checklist
Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.