Skip to content

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Jul 22, 2025

Motivation and Context

We need the ability to support getting User Approvals/Input for various scenarios:

  1. Server side tool invocations / MCP calls in an agent or inference service
  2. Client side function invocations inside an Agent that needs approval
  3. Any other functionality in an agent that needs user approval
  4. User input requests from the agent.

#222

Description

  • This adds an ADR describing the problem in more detail and outlining options.

NOTE: We should prototype some parts of the suggested solution

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the SK Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • I didn't break anyone 😄

@westey-m westey-m requested review from Copilot and stephentoub July 22, 2025 13:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an Architecture Decision Record (ADR) that proposes a new user approval mechanism for agent systems. The document outlines the need for user approval in scenarios involving server-side tool invocations, client-side function calls, and other agent operations requiring explicit user consent.

Key changes:

  • Documents the problem of requiring user approvals in agent workflows
  • Proposes new ApprovalRequestContent and ApprovalResponseContent content types
  • Details implementation flows for both ChatClientAgent and CustomAgent scenarios

@eavanvalkenburg eavanvalkenburg added the documentation Improvements or additions to documentation label Jul 23, 2025
@westey-m
Copy link
Contributor Author

Closing this PR, as all the required code has been merged separately and there is a separate PR for just merging the adr doc.

@westey-m westey-m closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation .NET

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants