.NET: Improve fidelity of OpenAI Responses hosting #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
github-actions
bot
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR migrates from the OpenAI SDK types to generated types for Responses, improving fidelity with streaming output. The changes restructure the responses implementation to use custom generated models instead of the OpenAI SDK types, while maintaining the same CreateResponse API functionality.
Key changes:
- Replaced OpenAI SDK types with generated types for response handling
- Implemented new converter classes for transforming between agent responses and generated models
- Restructured streaming response processing with new event generation approach
Reviewed Changes
Copilot reviewed 16 out of 614 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ResponseConverterExtensions.cs | New converter for transforming agent responses to Response models |
| RequestConverterExtensions.cs | New converter for extracting input messages from CreateResponse |
| AfItemResourceGenerator.cs | New generator for creating item resources from streaming agent updates |
| SingletonOptionsMonitor.cs | Utility class for singleton options monitoring |
| ModelConversionExtensions.cs | Extension methods for converting between model types |
| IIdGenerator.cs | Interface and extensions for generating various types of IDs |
| DefaultIdGenerator.cs | Default implementation of ID generator with Foundry-style IDs |
| CompositeDisposable.cs | Utility class for aggregating multiple disposable objects |
| AsyncEnumerableExtensions.cs | Extension methods for async enumerable operations |
| AIAgentResponsesProcessor.cs | Refactored processor to use generated types instead of OpenAI SDK |
| AssemblyInfo.cs | Added InternalsVisibleTo for test assembly access |
| Microsoft.Agents.AI.Hosting.OpenAI.csproj | Updated package references and removed unused warnings |
| HostApplicationBuilderExtensions.cs | New extension for configuring OpenAI Responses support |
| EndpointRouteBuilderExtensions.Responses.cs | Simplified endpoint mapping with new generated types |
| Program.cs | Added OpenAI Responses configuration to sample |
| Directory.Packages.props | Added System.ClientModel package reference |
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/Id/DefaultIdGenerator.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/AsyncEnumerableExtensions.cs
Outdated
Show resolved
Hide resolved
|
Does this replace #1542 ? |
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
stephentoub
reviewed
Oct 17, 2025
...rc/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Generated/Models/ComputerActionScreenshot.cs
Outdated
Show resolved
Hide resolved
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
Yes |
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
stephentoub
reviewed
Oct 18, 2025
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Microsoft.Agents.AI.Hosting.OpenAI.csproj
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/AsyncEnumerableExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/AsyncEnumerableExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/Id/DefaultIdGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Common/Id/DefaultIdGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Converters/AfItemResourceGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Oct 18, 2025
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Converters/AfItemResourceGenerator.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 22, 2025
...Microsoft.Agents.AI.Hosting.OpenAI/ChatCompletions/Utils/ChatCompletionsOptionsExtensions.cs
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/EndpointRouteBuilderExtensions.Responses.cs
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/EndpointRouteBuilderExtensions.Responses.cs
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/Converters/ItemContentConverter.cs
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…unResponseExtensions.cs Co-authored-by: Stephen Toub <[email protected]>
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
…unResponseExtensions.cs Co-authored-by: Stephen Toub <[email protected]>
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Failure
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
had a problem deploying
to
integration
GitHub Actions
Error
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
ReubenBond
temporarily deployed
to
integration
GitHub Actions
Inactive
stephentoub
approved these changes
Oct 22, 2025
ReubenBond
added a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
* Improve conformance of OpenAI Responses API serving * Update dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs Co-authored-by: Stephen Toub <[email protected]> * Update dotnet/src/Microsoft.Agents.AI.Hosting.OpenAI/Responses/AgentRunResponseExtensions.cs Co-authored-by: Stephen Toub <[email protected]> * Sort packages * Relax adherence where acceptable * nit * PromptCacheKey is not obsolete * format --------- Co-authored-by: Stephen Toub <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current Responses implementation does not match the streaming output produced by Responses.
Description
This PR migrates from the OpenAI SDK types to generated types for Responses and aligns output with the expected output.
The Responses HTTP API surface is still not fully covered, but this PR does not change that, and we can address it in a subsequent PR. Currently, only the CreateResponse API is supported.
Contribution Checklist