.NET: Tweak AgentAbstractionsJsonUtilities to better match AIJsonUtilities#1094
Merged
Conversation
Functional change includes setting the encoder used by the options and employing JsonStringEnumConverter.
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
stephentoub
temporarily deployed
to
integration
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the AgentAbstractionsJsonUtilities configuration with AIJsonUtilities by adding JavaScript encoder settings and enum string conversion support.
- Adds
UnsafeRelaxedJsonEscapingencoder for consistent JSON escaping behavior - Enables string-based enum serialization through
JsonStringEnumConverterandUseStringEnumConverter - Updates access modifier for internal JSON context class
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AgentAbstractionsJsonUtilities.cs | Configures encoder settings, adds enum string conversion, and updates JSON context visibility |
| AgentAbstractionsJsonUtilitiesTests.cs | Adds comprehensive unit tests for the new JSON serialization configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dmytrostruk
approved these changes
Oct 2, 2025
markwallace-microsoft
approved these changes
Oct 2, 2025
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
…icrosoft#1094) Functional change includes setting the encoder used by the options and employing JsonStringEnumConverter.
Arturo-Quiroga-MSFT
pushed a commit
to Arturo-Quiroga-MSFT/agent-framework-public
that referenced
this pull request
Nov 23, 2025
…icrosoft#1094) Functional change includes setting the encoder used by the options and employing JsonStringEnumConverter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional change includes setting the encoder used by the options and employing JsonStringEnumConverter.