feat(ai-win-ado-sep21): initial changes to replace WebBrowser control with WebView2 control #1205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR builds heavily on the draft in #1170 to replace the deprecated IE-based WebBrowser control with the newer WebView2 control so that bug filing in Azure DevOps is unblocked.
You can try the MSI here.
This changeset has the minimum set of changes to use the WebView2:
EnsureCoreWebView2Async
that we think were causingArgumentException
crashes similar to MessageBox.Show() fails after WebView2 is added to form MicrosoftEdge/WebView2Feedback#329 - we haven't noticed the crash since making the change, but will keep lookingIn the happy path, the old 'ADO issue filing is blocked' dialog is now gone, and users can file bugs again.
However, there are still several PRs to come:
We decided to approach this via several PRs that make their way into canary rather than a single atomic change. This means canary might have some buggy behavior in issue filing for now, but it's an improvement over the current blocked behavior.
Motivation
unblock azure devops issue filing
Context
This PR also introduces a new dialog box that accompanies a change in our documentation: https://github.com/microsoft/accessibility-insights-docs/pull/899
The WebView2 control requires a WebView2 runtime to be installed on the client machine. This requirement is also described in MicrosoftEdge/WebView2Feedback#341.
In April 2021, Microsoft began installing the WebView2 Runtime on Windows devices with Version 2101 or later of Microsoft 365 Apps installed. But some machines don't have the runtime installed (Windows 7, for example). We don't expect this to affect many users, but we need to provide information to users so they can install the runtime if needed.
As app owners we could also modify Accessibility Insights for Windows to install the WebView2 runtime directly for our users. After getting input from team members, we elected not to add to AI-Window's installation process. Instead, users without the runtime will follow these one-time steps.
This PR adds the dialog pictured above if the user does not have the runtime installed. The dialog will link to the published content in our documentation when completed.
Pull request checklist