fix: Allow system administrators to suppress telemetry by policy #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
commented
Sep 29, 2021
| /// <summary> | ||
| /// Whether or not telemetry toggle button is enabled in the settings. | ||
| /// </summary> | ||
| bool IsTelemetryAllowed { get; set; } | ||
| bool HasUserOptedIntoTelemetry { get; set; } |
There was a problem hiding this comment.
This is just a rename to better distinguish which level of enabling we are setting
DaveTryon
commented
Sep 29, 2021
| @@ -55,9 +55,9 @@ private void btnExit_Click(object sender, RoutedEventArgs e) | |||
| DialogResult = ckbxAgreeToHelp.IsChecked ?? false; | |||
|
|
|||
| if (DialogResult) | |||
| TelemetryController.EnableTelemetry(); | |||
| TelemetryController.OptIntoTelemetry(); | |||
There was a problem hiding this comment.
This is just a rename to better distinguish which level of enabling we are setting
DaveTryon
commented
Sep 29, 2021
| else | ||
| TelemetryController.DisableTelemetry(); | ||
| TelemetryController.OptOutOfTelemetry(); |
There was a problem hiding this comment.
This is just a rename to better distinguish which level of enabling we are setting
DaveTryon
commented
Sep 29, 2021
| @@ -631,7 +631,7 @@ public static ConfigurationModel GetDefaultConfigurationModel(FixedConfigSetting | |||
| FontSize = FontSize.Standard, | |||
| HighlighterMode = HighlighterMode.HighlighterBeakerTooltip, | |||
| ShowAncestry = true, | |||
| EnableTelemetry = true, | |||
| EnableTelemetry = false, | |||
There was a problem hiding this comment.
This isn't strictly necessary but better reflects what the default value should be
dbjorge
reviewed
Sep 29, 2021
src/AccessibilityInsights.SharedUx/Controls/SettingsTabs/ApplicationSettingsControl.xaml
Outdated
Show resolved
Hide resolved
dbjorge
reviewed
Sep 29, 2021
dbjorge
approved these changes
Sep 29, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Create a registry-based policy to disable telemetry from a computer. The suppression is system-wide and persists across uninstall/reinstall. The suppression is added by creating the following registry value:
Key: HKEY_LOCAL_MACHINE\SOFTWARE\Policies\Accessibility Insights for Windows
Value (DWORD): DisableTelemetry = 1
In terms of a reg file, it looks like this:
If this value exists and is set to 1, then the initial telemetry prompt is skipped. Inside the settings dialog, the standard telemetry block is also changed, as shown here:
The key is read when the app starts up, and changes to the key will be ignored until after the app is restarted.
Motivation
Addresses #1182
Context
I also walked through this extended scenario:
This works because the ShowTelemetryDialog flag defaults to true, then never gets set to false. When the registry override is removed, we display the telemetry dialog, as expected.
Pull request checklist