Skip to content

Conversation

@punker76
Copy link
Contributor

@punker76 punker76 commented Nov 11, 2020

Description of Change

This PR adds the target framework for .Net 5.0.

Bugs Fixed

Closes #80

API Changes

Added:

  • net5.0-windows target framework

Behavioral Changes

-/-

image

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

Note

Should we drop the netcoreapp3.0 target?

@punker76 punker76 force-pushed the feature/net50 branch 2 times, most recently from 5cbe775 to 7532acb Compare November 20, 2020 08:26
@mgoertz-msft
Copy link
Member

Should we drop the netcoreapp3.0 target?

Since 3.0 has been out of support since March it would make sense to drop it now.

Copy link
Member

@mgoertz-msft mgoertz-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punker76 Feel free to remove netcoreapp3.0 before merging.

@DVaughan Could you please publish this .NuGet.org when ready? Thanks!

@punker76
Copy link
Contributor Author

@mgoertz-msft netcoreapp3.0 is gone

@mgoertz-msft mgoertz-msft merged commit 462bcb7 into microsoft:master Nov 20, 2020
@mgoertz-msft
Copy link
Member

Thank you @punker76!

@punker76 punker76 deleted the feature/net50 branch November 20, 2020 16:00
@mageshsankar
Copy link

mageshsankar commented Dec 3, 2020

@mgoertz-msft When will you publish this to Nuget.org?

@mgoertz-msft
Copy link
Member

@DVaughan Could you please publish this new version to NuGet.org? Thank you!

@DVaughan
Copy link
Contributor

DVaughan commented Dec 9, 2020

There is an Microsoft internal pipeline issue that is preventing the package from being built. I'll publish the package as soon as that is resolved.

@mageshsankar
Copy link

@DVaughan @mgoertz-msft Could you please let me know the timeline for to publish in NuGet.org?

@DVaughan
Copy link
Contributor

@DVaughan @mgoertz-msft Could you please let me know the timeline for to publish in NuGet.org?

I'm currently working to make this happen and expect it to be available in the next week.

@DVaughan
Copy link
Contributor

DVaughan commented Jan 4, 2021

Package has been published: microsoft.xaml.behaviors.wpf.1.1.31

@mgoertz-msft
Copy link
Member

Nice, thank you @DVaughan!

@mageshsankar
Copy link

Hi Guys,

I have doubt, how to install nuget package without its dependencies. Im using below code to install nuget

Cake.Common.Tools.NuGet.NuGetAliases.NuGetInstall(context, packageid, new NuGetInstallSettings { NoCache = true, OutputDirectory = "../Packages", });

any idea about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants