Skip to content

Migrated sample csproj to SDK style - #187

Closed
Jan Ivar Carlsen (jizc) wants to merge 1 commit into
microsoft:mainfrom
jizc:feature/sdk-style-projects
Closed

Migrated sample csproj to SDK style#187
Jan Ivar Carlsen (jizc) wants to merge 1 commit into
microsoft:mainfrom
jizc:feature/sdk-style-projects

Conversation

@jizc

@jizc Jan Ivar Carlsen (jizc) commented Feb 26, 2025

Copy link
Copy Markdown

Description of Change

  • Migrated sample project file to modern SDK style
  • Removed empty Resources and Settings files to simplify sample project further

Bugs Fixed

Fixes #186

API Changes

None, only sample project is changed.

Behavioral Changes

None, only sample project is changed.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

@brianlagunas

Brian Lagunas (brianlagunas) commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

I'm sorry, I just realized you submitted this PR. We have a newer PR that we'll review in place of this one. Thank you for taking the time. I'll be sure to double check existing PRs before working on something :)

@jizc

Copy link
Copy Markdown
Author

Understood. For what it's worth, closing the newer PR in favor of this one would have felt a bit more fair given the timeline.

@brianlagunas

Brian Lagunas (brianlagunas) commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

You’re absolutely right... that’s a fair callout. Given the timeline, it would have been more fair to prioritize your PR instead of the newer one.

I didn’t catch that yours already covered this work before moving forward, and that’s on me. I should have taken more care to review existing PRs before making that decision.

I really appreciate you taking the time to contribute this, and I’m sorry for the frustration this caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the samples to the SDK style project

2 participants