Updating the command parameter binding for the ColorCommand property so null isn't being passed as the parameter value. #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so that it works properly and isn't always passing null.
brianlagunas
approved these changes
Dec 12, 2023
dpvreony
referenced
this pull request
in reactiveui/ReactiveUI
Jun 13, 2024
…22 (#3834) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.Xaml.Behaviors.Wpf](https://github.com/Microsoft/XamlBehaviorsWpf) ([source](https://github.com/microsoft/XamlBehaviorsWpf)) | `1.1.77` -> `1.1.122` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/XamlBehaviorsWpf (Microsoft.Xaml.Behaviors.Wpf)</summary> ### [`v1.1.122`](https://github.com/microsoft/XamlBehaviorsWpf/releases/tag/v1.1.122): Behaviors 1.1.122 ##### What's Changed This release fixes an issue in the XAMLBehaviorsSample.InvokeCommandControl Binding: - Updating the command parameter binding for the ColorCommand property so null isn't being passed as the parameter value by [@​smeddows](https://github.com/smeddows) in [https://github.com/microsoft/XamlBehaviorsWpf/pull/145](https://github.com/microsoft/XamlBehaviorsWpf/pull/145) **Full Changelog**: microsoft/XamlBehaviorsWpf@v1.1.77...v1.1.122 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/reactiveui/ReactiveUI). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJEZXBlbmRlbmN5IE1hbmFnZW1lbnQiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixing the broken binding that was always passing
nullinto the command. Explicitly stated the element name and then passed in the 'Background' property. Cast the parameter in the code behind with the CommandBugs Fixed
This should fix the issue found in (Issue #144)[https://github.com//issues/144].
Changed:
Behavioral Changes
No changes to behavior are expected.