Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User/dahoehna/api contracts #2110

Merged
merged 17 commits into from
Mar 16, 2022
Merged

User/dahoehna/api contracts #2110

merged 17 commits into from
Mar 16, 2022

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Feb 16, 2022

Adding documentation got API contracts.

@ghost ghost added the needs-triage label Feb 16, 2022
@dhoehna dhoehna requested a review from jonwis February 16, 2022 21:41
BenJKuhn
BenJKuhn reviewed Feb 16, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
BenJKuhn
BenJKuhn reviewed Feb 16, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
BenJKuhn
BenJKuhn reviewed Feb 16, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
BenJKuhn
BenJKuhn reviewed Feb 16, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
riverar
riverar reviewed Feb 17, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
DrusTheAxe
DrusTheAxe previously requested changes Feb 17, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
DrusTheAxe
DrusTheAxe reviewed Feb 17, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
DrusTheAxe
DrusTheAxe reviewed Feb 17, 2022
View reviewed changes
docs/WinRTAPIContracts.md Outdated Show resolved Hide resolved
docs/Coding-Guidelines.md Outdated Show resolved Hide resolved
@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 1, 2022

I did leave a TODO in the spec on purpose. I'm still looking into forbidden interface changes. However, everything else can be reviewed.

@dhoehna dhoehna mentioned this pull request Mar 2, 2022
Merged
@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jevansaks
jevansaks reviewed Mar 3, 2022
View reviewed changes
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
DrusTheAxe
DrusTheAxe reviewed Mar 4, 2022
View reviewed changes
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
DrusTheAxe
DrusTheAxe reviewed Mar 4, 2022
View reviewed changes
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
@DrusTheAxe DrusTheAxe self-requested a review March 4, 2022 00:18
@dhoehna dhoehna mentioned this pull request Mar 8, 2022
Merged
@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 10, 2022

@DrusTheAxe I believe I have addressed your comments.

DrusTheAxe
DrusTheAxe reviewed Mar 10, 2022
View reviewed changes
specs/WinRT/WinRTAPIContracts.md Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 15, 2022

/azp run

@dhoehna dhoehna requested a review from DrusTheAxe March 15, 2022 16:27
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 16, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

DefaultRyan
DefaultRyan approved these changes Mar 16, 2022
View reviewed changes
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
specs/WinRT/WinRTAPIContracts.md Outdated Show resolved Hide resolved
@DefaultRyan
Copy link
Member

Couple of minor nits, but I believe this works. Let's check it in.

@dhoehna dhoehna dismissed DrusTheAxe’s stale review March 16, 2022 18:14

Changes have been addressed.

@dhoehna
Copy link
Contributor Author

dhoehna commented Mar 16, 2022

/azp run

@dhoehna dhoehna enabled auto-merge (squash) March 16, 2022 18:14
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dhoehna dhoehna merged commit 0aad50b into main Mar 16, 2022
@dhoehna dhoehna deleted the user/dahoehna/ApiContracts branch March 16, 2022 21:21
@dhoehna dhoehna mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevansaks jevansaks jevansaks left review comments

@jonwis jonwis jonwis left review comments

@BenJKuhn BenJKuhn BenJKuhn left review comments

@riverar riverar riverar left review comments

@DefaultRyan DefaultRyan DefaultRyan approved these changes

@DrusTheAxe DrusTheAxe Awaiting requested review from DrusTheAxe

Assignees

@dhoehna dhoehna

Labels
api-design Updates to Project Reunion API surfaces area-Infrastructure Build, test, source layout, package construction (TODO: move to Deployment, DeveloperTools) feature proposal
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
8 participants
@dhoehna @DefaultRyan @DrusTheAxe @riverar @BenJKuhn @jonwis @jevansaks @bpulliam