Skip to content

Commit

Permalink
User/erlangl/fi develop into feature (#2660)
Browse files Browse the repository at this point in the history
* Fix issue where WinUI C# and C++ item templates are not appearing in WinUI projects

* Making EM RS5+. Limiting the tracking capability to Windows11+ (Spec) (#2544)

* Updating spec

* Adressing comments

* More changes

Co-authored-by: Darren Hoehna <[email protected]>

* Create a pipeline to automate FIs from main to develop (#2610)

* v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592 (#2608)

* v1.1 SDK throws an access violation from MddBootstrapInitialize's logging code if no matching packages are installed #2592

* Telemetry char/string. AppData DataStore-1.0.

* Retrieve the *Main* package's family name for AppData

* Add/Remove the test Main package (DataStore) just like we do the test Framework

* Detoured GetCurrentPackageInfo3() should route to the OS any PackageInfoType value it doesn't handle (#2623)

* Create tsaoptions.json

* Create WindowsAppSDK-BinaryAnalysis-steps.yml

* Create WindowsAppSDK-SourceAnalysis-job.yml

* Update build-mrt.yml

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-CI.yml

* Delete WindowsAppSDK-SourceAnalysis-job.yml

* Delete WindowsAppSDK-BinaryAnalysis-steps.yml

* Create WindowsAppSDK-BinaryAnalysis-steps.yml

* Create WindowsAppSDK-SourceAnalysis-job.yml

* Update WindowsAppSDK-BuildDevProject-Steps.yml

* Update WindowsAppSDK-BuildProject-Steps.yml

* Update WindowsAppSDK-BuildSolution-Steps.yml

* Update ProjectReunion-CI.yml

* Update ProjectReunion-BuildFoundation.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update build-mrt.yml

* Update ProjectReunion-BuildFoundation.yml

* Update WindowsAppSDK-BinaryAnalysis-steps.yml

* Update WindowsAppSDK-BinaryAnalysis-steps.yml

* Update WindowsAppSDK-BuildProject-Steps.yml

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-CI.yml

* Update WindowsAppSDK-BuildDevProject-Steps.yml

* Update WindowsAppSDK-BuildProject-Steps.yml

* Update WindowsAppSDK-BuildSolution-Steps.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update WindowsAppSDK-BinaryAnalysis-steps.yml

* Update build-mrt.yml

* Update ProjectReunion-CI.yml

* Update WindowsAppSDK-BinaryAnalysis-steps.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Do a compiler options pass on all binaries contributing to WinAppSDK (#2629)

Tweak various compiler options for optimization (e.g. /GR-) and correctness/productivity (e.g. /W4).

Project-wide standardization via new \WindowsAppSDK.Build.Cpp.props. See for more details.

Corrected several inconsistencies across projects e.g. given Debug|Release + x86+x64+arm64 = 6 permutations, but some projects had an option set for only 5, or only 1. Most projects were mostly already setting most of these options so their changes were mostly removing the now-redundant project-specific setting and let the top-level project-wide standards handle it.

This now standardizes all C++ projects to...
* Compile (all): `/W4 /sdl /permissive- /std:c++17 /GR-` (except 2 projects that explicitly set `/std:c++20`)
* Compile (debug): `/Od`
* Compile (release): `/GS /GF /GL /Gy /Gw /Ob2 /Oi /Os /Oy`
* Link (debug) `/DEBUG:FULL /INCREMENTAL`
* Link (release): `/INCREMENTAL:NO /LTCG /OPT:ICF /OPT:REF`

https://task.ms/39994837 Foundation

https://task.ms/39994852 MRTCore

* Add standardized (project-wide) C++ compile and link options

* Remove ARM support (not supported, but some ARM-conditional fragments weren't removed)

* Removed <WarningLevel> from all projects. Fixed up warnings masked by projects who'd set Level3

* Added SDLCheck for all builds. Added Disable-Optimization for Debug builds. Remove properties in *vcxproj redundnat with standardized options

* Removed redundant <Optimization> from *vcxproj

* Fixed warnings. Removed unnecessary delayload

* Fixed some inconsistencies in project settings

* Fixed AccessControlTests weren't copying the Bootstrap dll to the test's OutDir and thus the test dll wouldn't load

* Fix some warnings in MRT. Had to disable read-only string pooling and strictstrings as workaround for some funky issues in MrtBaseUnitTests for now; filed bug for follow up to fix the errors

* Corrected some comments. Added the missing LTCG option

* Changed LTCG from fast to normal

* Updated FavorSizeOrSpeed to Size instead of Speed

* Move LinkIncremental=false for Release builds to the top-level project-wide standard

* Host LinkIncremental=true if Configuration=Debug to be project wide setting (projects were routinely doing this locally, but inconsistently)

* Fixed a comment

* Added a cautionary note about why Detours.vcxproj has seemingly redundant or contradictory options and to be wary of making any changes

* Removed options redundant with WindowsAppSDK.Build.Cpp.props

* Elevate GenerateDebugInformation=Full to project-wide and remove redundancies. Move dev\WindowsAppSDK.Build.Cpp.props content to project wide (not just \dev) and delete the now obsolete dev\WindowsAppSDK.Build.Cpp.props (really only amounted to /ZH:SHA_256).

* Incorporated feedback

* Overhaul NuGet versions to include "main" or "develop" (#2636)

* Some old MSTest.pfx references were lingering (and now breaking things) (#2638)

* Installation with System-Account doesn't work #2546 (#2565)

* Installation with System-Account doesn't work #2546 
Co-authored-by: Santosh Chintalapati <[email protected]>

* Fix the .NET SDK installer script used by MRT Core, and don't run the script anymore (#2640)

* Fix the .NET SDK install script.

* Remove .NET SDK version from global.json file.

* Don't run the DownloadDotNetCoreSdk.ps1 script in the pipeline.

* Update build-mrt.yml

* Update DownloadDotNetCoreSdk.ps1

* Update global.json

* Update WindowsAppSDK-BinaryAnalysis-steps.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update global.json

* Update global.json

* Update build-mrt.yml

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-CI.yml

* Update WindowsAppSDK-BuildDevProject-Steps.yml

* Update WindowsAppSDK-BuildProject-Steps.yml

* Update WindowsAppSDK-BuildProject-Steps.yml

* Update WindowsAppSDK-BuildSolution-Steps.yml

* Add 1.1.1 & 1.0.4 to bug template and remove outdated versions (#2627)

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-CI.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update ProjectReunion-BuildFoundation.yml

* Update ProjectReunion-CI.yml

* Update WindowsAppSDK-SourceAnalysis-job.yml

* Update ProjectReunion-CI.yml

* Update Newtonsoft.Json explicit reference in Dev16 projects to work around vulnerability in older versions (#2662)

Co-authored-by: James Parsons <[email protected]>
Co-authored-by: Darren Hoehna <[email protected]>
Co-authored-by: Darren Hoehna <[email protected]>
Co-authored-by: reunion-maestro-bot <[email protected]>
Co-authored-by: Kyaw Thant <[email protected]>
Co-authored-by: Howard Kapustein <[email protected]>
Co-authored-by: alexlamtest <[email protected]>
Co-authored-by: Jeff Genovy <[email protected]>
Co-authored-by: Gabby Bilka <[email protected]>
Co-authored-by: Eric Langlois <[email protected]>
Co-authored-by: Ryan Shepherd <[email protected]>
  • Loading branch information
12 people authored Jun 24, 2022
1 parent 71a2da7 commit 9be0803
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="16.0.206" ExcludeAssets="runtime">
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.0.3177-preview3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="16.0.206" ExcludeAssets="runtime">
<IncludeAssets>compile; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
<PackageReference Include="System.Net.Http" Version="4.3.4" />
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.0.3177-preview3">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down

0 comments on commit 9be0803

Please sign in to comment.