Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format change error for YUY2 #984

Merged

Conversation

jiteshkris
Copy link
Contributor

No description provided.

@jiteshkris jiteshkris changed the title fix formating change error fix format change error for NV12 May 9, 2023
@jiteshkris jiteshkris changed the title fix format change error for NV12 fix format change error for YUY2 May 9, 2023
@jiteshkris
Copy link
Contributor Author

@NaveenThum is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@SangChoe is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@chrilaMSFT is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@kasumman is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@LPBourret is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@j-leungyy is added to the review. #Closed

@jiteshkris
Copy link
Contributor Author

@gerritsMSFT is added to the review. #Closed

GUID m_streamCategory;
ULONG m_cRef;
protected:
IMFDeviceTransform* m_pTransform; /* Weak reference to the the device MFT */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/* Weak refe

nit - fix alignment of /*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the member m_pTransform itself as well

@@ -473,6 +473,7 @@ class CDecoderTee : public CVideoProcTee {
DWORD m_lNeedInputRequest;
GUID m_streamCategory; // Needed for bind flags
BOOL m_bXvpAdded;
ComPtr<CVideoProcTee> m_spXvp;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m_spXvp

Could this be anything but an Xvptee (e.g., decodertee)? If so, change the name of variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to change too much.

@NaveenThum
Copy link

I guess these changes are not in OS repo yet. Is the plan to mirror these changes once they go on GitHub?

@@ -1292,7 +1292,10 @@ UpdateAllocatorAttributes(
level = spDevice->GetFeatureLevel();
dwBindFlags |= ((level >= D3D_FEATURE_LEVEL_10_0) ? D3D11_BIND_SHADER_RESOURCE : 0);
}

else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else

Doesn't this make the line 1269 meaningless?
Or is D3D11_BIND_RENDER_TARGET considered as fallback value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a fallback value

@jiteshkris
Copy link
Contributor Author

jiteshkris commented Aug 16, 2023

I guess these changes are not in OS repo yet. Is the plan to mirror these changes once they go on GitHub?

I will make these changes after I check this in #Resolved

@NeoAdonis NeoAdonis merged commit d35df21 into microsoft:develop Aug 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants