Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CGColorSpaceGetColorTable(+Count) & Tests #2397

Merged
merged 2 commits into from
Apr 3, 2017

Conversation

msft-Jeyaram
Copy link
Contributor

fixes #2387

@DHowett-MSFT DHowett-MSFT changed the title Implementation ofCGColorSpaceGetColorTableCount & CGColorSpaceGetColorTable w/ unittests Implement CGColorSpaceGetColorTable(+Count) & Tests Mar 31, 2017
@DHowett-MSFT
Copy link

Pull request renamed. 😄

@msft-Jeyaram
Copy link
Contributor Author

msft-Jeyaram commented Mar 31, 2017

@DHowett-MSFT thanks Dustin

UNIMPLEMENTED();
RETURN_IF(!space);
RETURN_IF(!table);
return space->GetTable(table);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd prefer CopyColorTable or CopyColorTableToBuffer

@msft-Jeyaram msft-Jeyaram merged commit 359fa6a into microsoft:develop Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CGColorSpace: Implement CGColorSpaceGetColorTableCount & CGColorSpaceGetColorTable
3 participants