Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation Dependency Removal] Should use use CoreFoundation vs Foundation: Strings should be created via CFSTR vs NS #2361

Merged
merged 3 commits into from
Mar 30, 2017
Merged

[Foundation Dependency Removal] Should use use CoreFoundation vs Foundation: Strings should be created via CFSTR vs NS #2361

merged 3 commits into from
Mar 30, 2017

Conversation

msft-Jeyaram
Copy link
Contributor

@aballway
Copy link
Contributor

#import "_CGLifetimeBridgingType.h"

Should this go as well?

Refers to: Frameworks/CoreGraphics/CGColorSpace.mm:25 in 19da71a. [](commit_id = 19da71a, deletion_comment = False)

@ms-jihua
Copy link
Contributor

Is there broader scoped context to this change? (Are we looking to remove enough dependencies that we can make some sort of build change, or are we just removing dependencies for code quality's sake?)

@msft-Jeyaram
Copy link
Contributor Author

@aballway yes yes yes
@ms-jihua this is a small part of the grand plan of completely removing Foundation/UIKit dependencies from CoreText and CoreGraphics

@msft-Jeyaram
Copy link
Contributor Author

There are few more instances, updating CR.

aballway
aballway approved these changes Mar 29, 2017
View reviewed changes
Copy link
Contributor

@aballway aballway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩

@msft-Jeyaram msft-Jeyaram merged commit 995f2af into microsoft:develop Mar 30, 2017
@msft-Jeyaram msft-Jeyaram mentioned this pull request Apr 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-jihua ms-jihua ms-jihua approved these changes

@rajsesh rajsesh rajsesh approved these changes

@aballway aballway aballway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@msft-Jeyaram @aballway @ms-jihua @rajsesh @msftclas