Telemetry: Record when a mount succesfully starts #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilbaker
reviewed
Oct 29, 2018
| @@ -141,7 +141,8 @@ public void Mount(EventLevel verbosity, Keywords keywords) | |||
| // Use TracingConstants.MessageKey.InfoMessage rather than TracingConstants.MessageKey.CriticalMessage | |||
| // as this message should not appear as an error | |||
| { TracingConstants.MessageKey.InfoMessage, "Virtual repo is ready" }, | |||
| }); | |||
| }, | |||
| Keywords.Telemetry); | |||
There was a problem hiding this comment.
Should this still be EventLevel.Critical, or can we make this Info level (see line 137)?
CC: @sanoursa. Saeed, do you remember if we perviously got push back for Critical + Telemetry events?
There was a problem hiding this comment.
I discussed this with @sanoursa offline and he agreed this should no longer be Critical.
There was a problem hiding this comment.
Thanks @wilbaker , I updated as suggested
wilbaker
suggested changes
Oct 30, 2018
jeschu1
force-pushed
the
virtualrepoready
branch
from
13b72ec to
76ee853
Compare
wilbaker
approved these changes
Oct 31, 2018
jrbriggs
added
the
affects: live-site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a telemetry marker so we can tell if a mount successfully came up