-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Engineering] Move build dependencies feed. #435
Conversation
nuget.config
Outdated
@@ -5,11 +5,12 @@ | |||
</config> | |||
<packageSources> | |||
<clear /> | |||
<add key="GVFSBuildDependencies" value="https://www.myget.org/F/gvfsbuilddependencies/api/v3/index.json" /> | |||
<add key="VFSForGitBuildDependencies" value="https://vfsforgit.myget.org/F/build-dependencies/api/v3/index.json" /> | |||
<add key="ArchivedGVFSBuildDependencies" value="https://vfsforgit.myget.org/F/gvfsbuilddependencies/api/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this key? The new feed has all of our latest packages, right? And the older commits still reference the original feed and it's not going away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vfsforgit.myget.org/F/build-dependencies
is currently empty.
vfsforgit.myget.org/F/gvfsbuilddependencies
is what was migrated from www.myget.org/F/gvfsbuilddependencies
.
I guess another option would be to rename gvfsbuilddependencies
but I couldn't figure out how to do that in a couple minutes of poking around the myget ui. Given that, I wanted to take this opportunity to move away from the gvfs name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just migrate the latest version of each package over to the new feed, and drop this archived feed from our code altogether. There's not much value in preserving two feeds here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I'll make those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved the packages that I think are needed to build this commit. CI should be able to fact check me :)
@@ -5,11 +5,12 @@ | |||
</config> | |||
<packageSources> | |||
<clear /> | |||
<add key="GVFSBuildDependencies" value="https://www.myget.org/F/gvfsbuilddependencies/api/v3/index.json" /> | |||
<add key="VFSForGitBuildDependencies" value="https://vfsforgit.myget.org/F/build-dependencies/api/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing this feed in with my user. Have we pushed any packages to this new feed? Do we need to update the builds to push to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we'll need to update the relevant builds to push to the new feed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kewillford do you see the feed when you log into vfsforgit.myget.org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see the old jobriggs/gvfsbuilddependencies one listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've mirrored the permissions from the old feed. Hopefully that fixes the issue.
The API key for myget is also used to push packages for the ProjFS team. I'm assuming with this new feed there will be a new API key to use and we will need to let them know. |
Upgrade the feeds to myget enterprise.