Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engineering] Move build dependencies feed. #435

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

jrbriggs
Copy link
Member

@jrbriggs jrbriggs commented Oct 26, 2018

Upgrade the feeds to myget enterprise.

nuget.config Outdated
@@ -5,11 +5,12 @@
</config>
<packageSources>
<clear />
<add key="GVFSBuildDependencies" value="https://www.myget.org/F/gvfsbuilddependencies/api/v3/index.json" />
<add key="VFSForGitBuildDependencies" value="https://vfsforgit.myget.org/F/build-dependencies/api/v3/index.json" />
<add key="ArchivedGVFSBuildDependencies" value="https://vfsforgit.myget.org/F/gvfsbuilddependencies/api/v3/index.json" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this key? The new feed has all of our latest packages, right? And the older commits still reference the original feed and it's not going away?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vfsforgit.myget.org/F/build-dependencies is currently empty.

vfsforgit.myget.org/F/gvfsbuilddependencies is what was migrated from www.myget.org/F/gvfsbuilddependencies.

I guess another option would be to rename gvfsbuilddependencies but I couldn't figure out how to do that in a couple minutes of poking around the myget ui. Given that, I wanted to take this opportunity to move away from the gvfs name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just migrate the latest version of each package over to the new feed, and drop this archived feed from our code altogether. There's not much value in preserving two feeds here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll make those changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the packages that I think are needed to build this commit. CI should be able to fact check me :)

@@ -5,11 +5,12 @@
</config>
<packageSources>
<clear />
<add key="GVFSBuildDependencies" value="https://www.myget.org/F/gvfsbuilddependencies/api/v3/index.json" />
<add key="VFSForGitBuildDependencies" value="https://vfsforgit.myget.org/F/build-dependencies/api/v3/index.json" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this feed in with my user. Have we pushed any packages to this new feed? Do we need to update the builds to push to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we'll need to update the relevant builds to push to the new feed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kewillford do you see the feed when you log into vfsforgit.myget.org?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see the old jobriggs/gvfsbuilddependencies one listed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mirrored the permissions from the old feed. Hopefully that fixes the issue.

@kewillford
Copy link
Member

The API key for myget is also used to push packages for the ProjFS team. I'm assuming with this new feed there will be a new API key to use and we will need to let them know.

@jrbriggs jrbriggs merged commit 6532cc9 into microsoft:master Oct 26, 2018
@jrbriggs jrbriggs deleted the move-feeds branch October 26, 2018 21:54
@jrbriggs jrbriggs added this to the S147 milestone Feb 7, 2019
@jrbriggs jrbriggs added the affects: engineering Keeping the engineering system healthy label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: engineering Keeping the engineering system healthy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants