[Engineering] Centralize special Mac paths in InitializeEnviroment.sh #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanoursa
approved these changes
Oct 24, 2018
Scripts/Mac/InitializeEnvironment.sh
Outdated
| export VFS_ENLISTMENTDIR=$VFS_SRCDIR/.. | ||
| export VFS_OUTPUTDIR=$VFS_ENLISTMENTDIR/BuildOutput | ||
| export VFS_PUBLISHDIR=$VFS_ENLISTMENTDIR/Publish | ||
| export VFS_PACKAGESDIR=$VFS_ENLISTMENTDIR/packages |
There was a problem hiding this comment.
Nit: a final newline makes the file more cat-friendly
Scripts/Mac/NukeBuildOutputs.sh
Outdated
| echo git --work-tree=$VFS_SRCDIR clean -Xdf -n | ||
| git --work-tree=$VFS_SRCDIR clean -Xdf -n |
Scripts/Mac/NukeBuildOutputs.sh
Outdated
|
|
||
| SRCDIR=$SCRIPTDIR/../.. | ||
| ROOTDIR=$SRCDIR/.. | ||
| sudo rm -Rf $VFS_ENLISTMENTDIR/BuildOutput |
There was a problem hiding this comment.
Use $VFS_OUTPUTDIR? In general, can we get rid of $VFS_ENLISTMENTDIR everywhere and not even export it from the init script?
There was a problem hiding this comment.
Good point -- yeah, I think we can.
wilbaker
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.