ProjFSFilter: Be more robust to missing PowerShell #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user had issues and we started a support line. Their diagnose log had _thousands_ of service logs. These were all failing with a call stack pointing to the method changed here. The only explanation I can think of is that PowerShell is not available on their system! Signed-off-by: Derrick Stolee <[email protected]>
kewillford
reviewed
Apr 17, 2020
This will throw a new PowershellNotFoundException if not found, but this is a private static method. One caller catches this exception explicitly, and then returns an "invalid" mode. The only other caller only happens if the first returns "disabled" instead. Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee
added a commit
that referenced
this pull request
May 28, 2020
…vironment.Exit() A user reported an issue via the Teams channel. Looking at the diagnose logs I saw that the user's `GVFS.Service` was restarting in a loop with an exception tracking down to this `Environment.Exit()` call. It's completely unacceptable to exit here, as it kills the service and then it restarts. Better to have no upgrades than to let this continue. The cause of this exception was a missing executable when checking `ProjFS.IsGVFSUpgradeSupported()`, which seems to call PowerShell. The only reason the stack would have a `Win32Exception` with "The system cannot find the file specified" is that `powershell.exe` is not on the `PATH`, which was fixed in #1658.
derrickstolee
added a commit
that referenced
this pull request
Jun 2, 2020
Includes the following pull requests: * #1663: Update Git to v2.27.0 * #1669: Docs: more troubleshooting and FAQs * #1668: ProductUPgradeTimer: remove unacceptable Environment.Exit() * #1664: Update USN journal entries for projected folders * #1666: Docs: start basic template * #1658: ProjFSFilter: Be more robust to missing PowerShell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user had issues and we started a support line. Their diagnose log
had thousands of service logs. These were all failing with this call
stack pointing to the method changed here:
The only explanation I can think of is that PowerShell is not
available on their system!