-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6319: Add support for --t: es5
and --m es6
#9042
Conversation
@@ -0,0 +1,12 @@ | |||
=== tests/cases/compiler/es6modulekindWithES5Target9.ts === |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code here looks different from tests/baselines/reference/es6modulekindWithES5Target9.js ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. earlier files that i have used and did not delete.
import {a} from "mod"; | ||
|
||
import * as M from "mod"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add usage of d, a, M etc to verify exports.identifier is not being emitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@sheetalkamat any more comments? |
👍 |
CC @Victorystick! |
Woop! This is fantastic news! 🎉 In which stable version can we expect to see these changes? |
Yey, great to see this feature! 🎉 @Victorystick The roadmap lists it underneath 2.0. |
It was merged into |
correct. today's build should have the fix. it should be shipped as part of the next release (TS 2.0). |
Fixes #6319.