Skip to content

Add option to bail out of jake runtests when a test fails #8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 3 commits into from
Closed

Add option to bail out of jake runtests when a test fails #8925

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67e6687
Add option to bail out of `jake runtests` when a test fails
Jun 1, 2016
4450bfb
Add bail option to runtests-parallel too
Jun 3, 2016
c04075d
Fix error
Jun 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Jakefile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,13 +755,18 @@ function runConsoleTests(defaultReporter, runInParallel) {
// schedule work for chunks
configFiles.forEach(function (f) {
var configPath = path.join(taskConfigsFolder, f);
var workerCmd = "mocha" + " -t " + testTimeout + " -R " + reporter + " " + colors + " " + run + " --config='" + configPath + "'";
var workerCmd = "mocha" + " -t " + testTimeout + " -R " + reporter + " " + colors + bail + " " + run + " --config='" + configPath + "'";
console.log(workerCmd);
exec(workerCmd, finishWorker, finishWorker)
});

function finishWorker(e, errorStatus) {
counter--;

if (bail && errorStatus !== undefined) {
failWithStatus(firstErrorStatus);
Copy link
Member

@sandersn sandersn Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fail with the correct number of errors? I don't think firstErrorStatus would be assigned until after the next if block.

I guess the fix would be to move below the next if block or just return errorStatus

}

if (firstErrorStatus === undefined && errorStatus !== undefined) {
firstErrorStatus = errorStatus;
}
Expand Down Expand Up @@ -810,7 +815,7 @@ function runConsoleTests(defaultReporter, runInParallel) {
}

var testTimeout = 20000;
desc("Runs all the tests in parallel using the built run.js file. Optional arguments are: t[ests]=category1|category2|... d[ebug]=true.");
desc("Runs all the tests in parallel using the built run.js file. Optional arguments are: t[ests]=category1|category2|... d[ebug]=true bail=false.");
task("runtests-parallel", ["build-rules", "tests", builtLocalDirectory], function() {
runConsoleTests('min', /*runInParallel*/ true);
}, {async: true});
Expand Down