Port #6769 to release-1.8 #6795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 064de38)
zhengbli
changed the title
Contributor
|
why are we porting this to 1.8? |
Contributor
Author
|
Are there concerns not to do so? I thought the routine updates are ported as long as the release was not done yet. |
Contributor
|
we have forked 1.8 already, we should only port changes bound to the release. so i would leave this change in 2.0, but not port it to 1.8 unless there is a need for that (i.e. address a 1.8 issue). |
Contributor
Author
|
Got it. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 064de38)
Port PR #6769 to release-1.8