Fixed an issue with excess/ common property check errors being incorrectly reported when relating to targets with multiple index signatures #60869
+812
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectly reported when relating to targets with multiple index signatures
Andarist
commented
Dec 29, 2024
| const propType = getNonMissingTypeOfSymbol(prop); | ||
| const type = exactOptionalPropertyTypes || propType.flags & TypeFlags.Undefined || keyType === numberType || !(prop.flags & SymbolFlags.Optional) | ||
| ? propType | ||
| : getTypeWithFacts(propType, TypeFacts.NEUndefined); | ||
| const related = isRelatedTo(type, targetInfo.type, RecursionFlags.Both, reportErrors, /*headMessage*/ undefined, intersectionState); | ||
| const related = isRelatedTo(type, targetInfo.type, RecursionFlags.Both, reportErrors, /*headMessage*/ undefined, intersectionState, targetInfo === getApplicableIndexInfo(target, propKeyType)); |
There was a problem hiding this comment.
This is where the allowExtraPropertyChecks is toggled~ when relating to a targetInfo.type. The source is related to all target infos (that's what the indexSignaturesRelatedTo caller does). Those checks should only be performed when relating to the applicable index info to reflect what happens in assignments like:
obj.indexSignatureProp = { someProp: 'foo' }In the example above, { someProp: string } is only related to the applicable index info "selected" by obj.indexSignatureProp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58442