feat(58447): JS object destructuring: allow to shorten expression when assignment is renamed back to original property value

[a-tarasyuk]

Fixes #58447

[jakebailey]

This looks great; been wanting this for ages...

Hopefully nobody actually wants the rename to duplicate the name? (I think linters actually fix this too in our favor.)

[andrewbranch]

What the baseline is showing is not the intended behavior. Here’s a real-world reproduction of the test:

Screen.Recording.2024-07-25.at.10.20.30.AM.mov

[jakebailey]

Oh, eek, yeah, I forgot that we'd need to do some step after getting the new text and then determine that they're the same, not do it early (which is what this PR does).

Oops

[andrewbranch]

I don’t want to derail this feature since I don’t know how much more work it would be to tack this on, but when I initially saw the issue, I thought it was talking about property assignments, not just destructuring. I run into this a lot too:

const foo = 0;
const obj = {
  bar: foo // <-- make shorthand when renaming 'bar' to 'foo' OR vice versa?
};

[DanielRosenwasser]

It feels like it would be confusing to have one but not the other to be honest.