Generic algorithm to create a shallow, memberwise clone of a node. #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // the original node. We also need to exclude specific properties and only include own- | ||
| // properties (to skip members already defined on the shared prototype). | ||
| const clone = location !== undefined | ||
| ? <T>createNode(node.kind, location.pos, location.end) |
There was a problem hiding this comment.
kind is copied again in the for loop, right? I just want to make sure I'm reading the code correctly.
There was a problem hiding this comment.
Good catch. I originally wrote the cloneNode function before @vladima modified the Node constructor, when kind was set on the prototype. I can probably drop isExcludedPropertyForClone in favor of clone.hasOwnProperty(key).
There was a problem hiding this comment.
This will copy over flags and parent now, won't it? Which is bad unless they are provided by the caller.
There was a problem hiding this comment.
No, flags and parent are set in the Node constructor. See line 808 of core.ts:
function Node(kind: SyntaxKind, pos: number, end: number) {
this.kind = kind;
this.pos = pos;
this.end = end;
this.flags = NodeFlags.None;
this.parent = undefined;
}And line 191 of services.ts:
constructor(kind: SyntaxKind, pos: number, end: number) {
this.kind = kind;
this.pos = pos;
this.end = end;
this.flags = NodeFlags.None;
this.parent = undefined;
}
|
Looks good to me. |
rbuckton
added a commit
that referenced
this pull request
Nov 20, 2015
Generic algorithm to create a shallow, memberwise clone of a node.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually will be needed for transformations.
Supports #5595.