Types cleanup #5597
Merged
Types cleanup #5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export interface EmptyStatement extends Statement { } | ||
|
|
||
| // @kind(SyntaxKind.DebuggerStatement) | ||
| export interface DebuggerStatement extends Statement { } |
There was a problem hiding this comment.
Consider adding brands to these.
There was a problem hiding this comment.
I'd rather not litter all of the interfaces with brands. They seem more valuable when disambiguating structurally similar nodes that may not be legally valid in certain parts of the tree (such as LeftHandSideExpression vs Expression).
If we ever end up with Enum type literals, I might change it to:
export interface EmptyStatement extends Statement {
kind: SyntaxKind.EmptyStatement;
}
...
|
👍 |
| export interface DebuggerStatement extends Statement { } | ||
|
|
||
| // @kind(SyntaxKind.MissingDeclaration) | ||
| // @factoryhidden("name", true) |
There was a problem hiding this comment.
what does facroryhidden and factoryParam mean?
There was a problem hiding this comment.
Sorry, meant to remove those.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit interfaces for various syntax kinds, adding some additional restrictions to types whose definition is too broad.
This is needed to support #5595.