Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to var in emitter, writer, printer #52906

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Switch to var in emitter, writer, printer #52906

merged 2 commits into from
Feb 22, 2023

Conversation

jakebailey
Copy link
Member

I'm probably missing more parts of this, but let's start with this and see.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 22, 2023
@jakebailey

This comment was marked as outdated.

Sign in to view
@typescript-bot

This comment was marked as outdated.

Sign in to view
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 22, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at bf41a3b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52906
Metric main 52906 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,475k (± 0.01%) 359,414k (± 0.01%) ~ 359,375k 359,502k p=0.065 n=6
Parse Time 3.48s (± 0.64%) 3.48s (± 0.65%) ~ 3.45s 3.51s p=0.935 n=6
Bind Time 1.12s (± 0.49%) 1.11s (± 0.57%) ~ 1.10s 1.12s p=0.201 n=6
Check Time 8.72s (± 0.54%) 8.67s (± 0.27%) -0.05s (- 0.61%) 8.64s 8.69s p=0.030 n=6
Emit Time 7.64s (± 0.58%) 7.41s (± 0.23%) 🟩-0.24s (- 3.07%) 7.39s 7.43s p=0.005 n=6
Total Time 20.96s (± 0.43%) 20.66s (± 0.13%) -0.30s (- 1.44%) 20.63s 20.71s p=0.005 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,629k (± 1.51%) 191,632k (± 1.53%) ~ 189,671k 195,546k p=0.810 n=6
Parse Time 1.49s (± 0.56%) 1.48s (± 1.01%) ~ 1.46s 1.50s p=0.928 n=6
Bind Time 0.77s (± 0.82%) 0.77s (± 0.82%) ~ 0.76s 0.78s p=1.000 n=6
Check Time 9.33s (± 0.62%) 9.35s (± 0.34%) ~ 9.32s 9.39s p=0.421 n=6
Emit Time 2.80s (± 1.03%) 2.75s (± 1.16%) -0.04s (- 1.61%) 2.71s 2.80s p=0.044 n=6
Total Time 14.38s (± 0.51%) 14.36s (± 0.38%) ~ 14.30s 14.43s p=0.687 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,885k (± 0.01%) 343,817k (± 0.01%) -68k (- 0.02%) 343,769k 343,860k p=0.031 n=6
Parse Time 2.62s (± 0.85%) 2.62s (± 1.01%) ~ 2.58s 2.66s p=1.000 n=6
Bind Time 1.01s (± 0.40%) 1.01s (± 0.74%) ~ 1.00s 1.02s p=1.000 n=6
Check Time 6.99s (± 0.20%) 7.00s (± 0.28%) ~ 6.96s 7.02s p=0.244 n=6
Emit Time 4.33s (± 1.24%) 4.21s (± 0.83%) -0.11s (- 2.66%) 4.17s 4.27s p=0.005 n=6
Total Time 14.95s (± 0.48%) 14.85s (± 0.29%) -0.11s (- 0.70%) 14.78s 14.91s p=0.019 n=6
TFS - node (v18.10.0, x64)
Memory used 299,920k (± 0.01%) 299,868k (± 0.01%) -52k (- 0.02%) 299,837k 299,926k p=0.037 n=6
Parse Time 2.05s (± 0.96%) 2.05s (± 0.97%) ~ 2.02s 2.08s p=0.935 n=6
Bind Time 1.14s (± 0.72%) 1.13s (± 0.48%) ~ 1.13s 1.14s p=0.859 n=6
Check Time 6.49s (± 0.33%) 6.49s (± 0.43%) ~ 6.46s 6.53s p=0.807 n=6
Emit Time 3.87s (± 0.39%) 3.84s (± 0.79%) -0.03s (- 0.86%) 3.81s 3.89s p=0.044 n=6
Total Time 13.56s (± 0.32%) 13.51s (± 0.30%) ~ 13.47s 13.58s p=0.078 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,190k (± 0.01%) 476,196k (± 0.01%) ~ 476,137k 476,240k p=0.688 n=6
Parse Time 3.16s (± 0.40%) 3.14s (± 0.43%) ~ 3.13s 3.16s p=0.087 n=6
Bind Time 0.91s (± 0.57%) 0.91s (± 0.60%) ~ 0.90s 0.91s p=0.640 n=6
Check Time 17.05s (± 0.54%) 17.12s (± 0.70%) ~ 16.96s 17.27s p=0.470 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.12s (± 0.43%) 21.16s (± 0.58%) ~ 20.98s 21.31s p=0.575 n=6
xstate - node (v18.10.0, x64)
Memory used 548,220k (± 0.01%) 548,139k (± 0.02%) ~ 547,936k 548,305k p=0.297 n=6
Parse Time 4.05s (± 0.46%) 4.07s (± 0.43%) ~ 4.05s 4.09s p=0.250 n=6
Bind Time 1.67s (± 0.82%) 1.67s (± 0.80%) ~ 1.65s 1.69s p=0.929 n=6
Check Time 2.77s (± 0.77%) 2.75s (± 0.75%) ~ 2.72s 2.77s p=0.089 n=6
Emit Time 0.08s (± 4.99%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=0.405 n=6
Total Time 8.57s (± 0.51%) 8.56s (± 0.23%) ~ 8.54s 8.59s p=0.520 n=6
Angular - node (v16.17.1, x64)
Memory used 358,849k (± 0.01%) 358,783k (± 0.00%) -66k (- 0.02%) 358,772k 358,809k p=0.005 n=6
Parse Time 3.71s (± 0.28%) 3.72s (± 0.45%) ~ 3.70s 3.74s p=0.559 n=6
Bind Time 1.19s (± 0.98%) 1.18s (± 0.35%) ~ 1.18s 1.19s p=0.248 n=6
Check Time 9.49s (± 0.41%) 9.49s (± 0.43%) ~ 9.44s 9.55s p=0.936 n=6
Emit Time 8.07s (± 0.76%) 7.90s (± 0.27%) -0.17s (- 2.09%) 7.87s 7.93s p=0.005 n=6
Total Time 22.45s (± 0.20%) 22.29s (± 0.18%) -0.16s (- 0.71%) 22.24s 22.36s p=0.005 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 191,372k (± 0.05%) 191,904k (± 0.67%) ~ 191,322k 194,527k p=0.378 n=6
Parse Time 1.56s (± 1.24%) 1.56s (± 1.02%) ~ 1.55s 1.59s p=1.000 n=6
Bind Time 0.82s (± 0.63%) 0.82s (± 0.63%) ~ 0.81s 0.82s p=1.000 n=6
Check Time 10.02s (± 0.25%) 10.08s (± 0.28%) +0.07s (+ 0.65%) 10.04s 10.11s p=0.006 n=6
Emit Time 3.07s (± 0.67%) 3.01s (± 0.62%) -0.06s (- 1.95%) 2.99s 3.03s p=0.005 n=6
Total Time 15.47s (± 0.29%) 15.48s (± 0.30%) ~ 15.42s 15.54s p=0.687 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,158k (± 0.01%) 343,068k (± 0.00%) -90k (- 0.03%) 343,045k 343,080k p=0.005 n=6
Parse Time 2.80s (± 0.67%) 2.80s (± 0.70%) ~ 2.78s 2.84s p=0.357 n=6
Bind Time 1.08s (± 0.38%) 1.08s (± 1.01%) ~ 1.06s 1.09s p=1.000 n=6
Check Time 7.66s (± 0.36%) 7.67s (± 0.42%) ~ 7.63s 7.71s p=0.871 n=6
Emit Time 4.53s (± 0.81%) 4.43s (± 0.40%) -0.11s (- 2.35%) 4.40s 4.44s p=0.005 n=6
Total Time 16.07s (± 0.47%) 15.98s (± 0.30%) -0.10s (- 0.59%) 15.94s 16.05s p=0.035 n=6
TFS - node (v16.17.1, x64)
Memory used 299,265k (± 0.01%) 299,236k (± 0.00%) -29k (- 0.01%) 299,212k 299,249k p=0.045 n=6
Parse Time 2.19s (± 0.47%) 2.19s (± 0.38%) ~ 2.19s 2.21s p=0.788 n=6
Bind Time 1.24s (± 0.98%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.351 n=6
Check Time 7.16s (± 0.50%) 7.19s (± 0.58%) ~ 7.12s 7.23s p=0.169 n=6
Emit Time 4.24s (± 0.69%) 4.34s (± 1.35%) +0.10s (+ 2.48%) 4.29s 4.45s p=0.005 n=6
Total Time 14.83s (± 0.32%) 14.97s (± 0.57%) +0.14s (+ 0.97%) 14.91s 15.14s p=0.006 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,473k (± 0.00%) 475,471k (± 0.00%) ~ 475,455k 475,495k p=0.336 n=6
Parse Time 3.32s (± 0.23%) 3.33s (± 0.41%) ~ 3.31s 3.35s p=0.931 n=6
Bind Time 0.96s (± 0.54%) 0.96s (± 0.00%) ~ 0.96s 0.96s p=0.174 n=6
Check Time 18.04s (± 0.31%) 17.99s (± 0.29%) ~ 17.91s 18.07s p=0.169 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.32s (± 0.24%) 22.27s (± 0.28%) ~ 22.19s 22.38s p=0.199 n=6
xstate - node (v16.17.1, x64)
Memory used 545,751k (± 0.01%) 545,679k (± 0.02%) ~ 545,594k 545,829k p=0.173 n=6
Parse Time 4.25s (± 0.47%) 4.24s (± 0.38%) ~ 4.22s 4.26s p=0.370 n=6
Bind Time 1.74s (± 0.36%) 1.75s (± 0.31%) ~ 1.74s 1.75s p=0.201 n=6
Check Time 2.97s (± 0.46%) 2.97s (± 0.35%) ~ 2.96s 2.99s p=0.870 n=6
Emit Time 0.10s (± 5.76%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=0.640 n=6
Total Time 9.05s (± 0.33%) 9.05s (± 0.30%) ~ 9.02s 9.09s p=0.627 n=6
Angular - node (v14.15.1, x64)
Memory used 352,559k (± 0.00%) 352,560k (± 0.00%) ~ 352,550k 352,568k p=0.936 n=6
Parse Time 3.71s (± 0.37%) 3.72s (± 0.50%) ~ 3.69s 3.74s p=0.935 n=6
Bind Time 1.25s (± 0.65%) 1.24s (± 0.33%) ~ 1.24s 1.25s p=0.248 n=6
Check Time 9.80s (± 0.44%) 9.80s (± 0.31%) ~ 9.77s 9.85s p=0.808 n=6
Emit Time 8.38s (± 0.56%) 8.31s (± 0.62%) ~ 8.26s 8.38s p=0.073 n=6
Total Time 23.14s (± 0.25%) 23.06s (± 0.21%) ~ 23.02s 23.13s p=0.065 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 186,652k (± 0.02%) 187,124k (± 0.68%) ~ 186,581k 189,741k p=0.092 n=6
Parse Time 1.58s (± 0.48%) 1.58s (± 0.35%) ~ 1.57s 1.58s p=0.137 n=6
Bind Time 0.84s (± 0.00%) 0.84s (± 0.75%) ~ 0.83s 0.85s p=1.000 n=6
Check Time 10.14s (± 0.42%) 10.19s (± 0.41%) ~ 10.14s 10.24s p=0.089 n=6
Emit Time 3.14s (± 1.21%) 3.11s (± 0.94%) ~ 3.07s 3.15s p=0.221 n=6
Total Time 15.70s (± 0.14%) 15.72s (± 0.42%) ~ 15.63s 15.79s p=0.747 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,109k (± 0.01%) 338,049k (± 0.01%) -60k (- 0.02%) 338,021k 338,077k p=0.005 n=6
Parse Time 2.88s (± 0.47%) 2.89s (± 1.19%) ~ 2.87s 2.96s p=0.805 n=6
Bind Time 1.09s (± 0.37%) 1.09s (± 0.58%) ~ 1.08s 1.10s p=0.673 n=6
Check Time 8.09s (± 0.57%) 8.07s (± 0.63%) ~ 8.00s 8.15s p=0.627 n=6
Emit Time 4.78s (± 0.67%) 4.66s (± 0.48%) -0.12s (- 2.44%) 4.62s 4.68s p=0.005 n=6
Total Time 16.84s (± 0.18%) 16.71s (± 0.27%) -0.13s (- 0.77%) 16.65s 16.78s p=0.005 n=6
TFS - node (v14.15.1, x64)
Memory used 294,271k (± 0.00%) 294,260k (± 0.00%) ~ 294,246k 294,271k p=0.107 n=6
Parse Time 2.39s (± 0.49%) 2.37s (± 0.53%) -0.02s (- 0.77%) 2.35s 2.38s p=0.040 n=6
Bind Time 1.06s (± 0.49%) 1.06s (± 0.49%) ~ 1.06s 1.07s p=1.000 n=6
Check Time 7.46s (± 0.71%) 7.46s (± 0.38%) ~ 7.41s 7.49s p=1.000 n=6
Emit Time 4.61s (± 0.65%) 4.27s (± 0.57%) 🟩-0.35s (- 7.51%) 4.25s 4.31s p=0.005 n=6
Total Time 15.53s (± 0.52%) 15.16s (± 0.29%) -0.37s (- 2.35%) 15.10s 15.21s p=0.005 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,129k (± 0.00%) 471,134k (± 0.01%) ~ 471,096k 471,164k p=0.748 n=6
Parse Time 3.48s (± 0.34%) 3.48s (± 0.38%) ~ 3.46s 3.50s p=0.933 n=6
Bind Time 0.99s (± 0.41%) 1.00s (± 0.55%) ~ 0.99s 1.00s p=0.282 n=6
Check Time 18.87s (± 0.36%) 18.89s (± 0.36%) ~ 18.81s 18.98s p=0.810 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.35s (± 0.29%) 23.37s (± 0.27%) ~ 23.28s 23.46s p=0.630 n=6
xstate - node (v14.15.1, x64)
Memory used 534,421k (± 0.00%) 534,398k (± 0.00%) -23k (- 0.00%) 534,379k 534,416k p=0.045 n=6
Parse Time 4.59s (± 0.51%) 4.58s (± 0.51%) ~ 4.55s 4.61s p=0.517 n=6
Bind Time 1.67s (± 0.31%) 1.66s (± 0.45%) ~ 1.65s 1.67s p=0.247 n=6
Check Time 3.13s (± 0.47%) 3.12s (± 0.39%) ~ 3.11s 3.14s p=0.084 n=6
Emit Time 0.10s (± 0.00%) 0.09s (± 4.45%) 🟩-0.01s (- 8.33%) 0.09s 0.10s p=0.007 n=6
Total Time 9.49s (± 0.17%) 9.46s (± 0.16%) -0.04s (- 0.39%) 9.43s 9.47s p=0.010 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52906 6
Baseline main 6

TSServer

Comparison Report - main..52906
Metric main 52906 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,361ms (± 0.29%) 2,367ms (± 0.57%) ~ 2,348ms 2,387ms p=0.336 n=6
Req 2 - geterr 5,305ms (± 0.48%) 5,310ms (± 0.68%) ~ 5,269ms 5,366ms p=0.936 n=6
Req 3 - references 338ms (± 1.02%) 336ms (± 0.62%) ~ 332ms 337ms p=0.254 n=6
Req 4 - navto 284ms (± 0.73%) 284ms (± 0.99%) ~ 281ms 287ms p=0.933 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 72ms (± 3.77%) 73ms (± 3.11%) ~ 71ms 77ms p=0.351 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,464ms (± 0.97%) 2,459ms (± 0.57%) ~ 2,445ms 2,479ms p=0.873 n=6
Req 2 - geterr 3,995ms (± 1.05%) 4,007ms (± 0.31%) ~ 3,990ms 4,021ms p=0.470 n=6
Req 3 - references 351ms (± 0.52%) 352ms (± 0.59%) ~ 349ms 355ms p=0.255 n=6
Req 4 - navto 293ms (± 1.14%) 292ms (± 0.37%) ~ 291ms 293ms p=0.663 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 68ms (± 2.84%) 68ms (± 0.00%) ~ 68ms 68ms p=0.290 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,154ms (± 0.60%) 3,162ms (± 1.22%) ~ 3,105ms 3,215ms p=0.575 n=6
Req 2 - geterr 1,622ms (± 0.63%) 1,615ms (± 0.20%) ~ 1,610ms 1,619ms p=0.166 n=6
Req 3 - references 104ms (± 1.87%) 103ms (± 1.14%) ~ 101ms 104ms p=0.462 n=6
Req 4 - navto 358ms (± 0.60%) 357ms (± 0.61%) ~ 353ms 359ms p=0.255 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 428ms (± 1.15%) 431ms (± 0.74%) ~ 428ms 435ms p=0.172 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,537ms (± 0.48%) 2,517ms (± 0.81%) ~ 2,489ms 2,547ms p=0.093 n=6
Req 2 - geterr 5,712ms (± 0.25%) 5,684ms (± 0.29%) -28ms (- 0.48%) 5,670ms 5,712ms p=0.024 n=6
Req 3 - references 350ms (± 0.74%) 348ms (± 0.84%) ~ 346ms 354ms p=0.293 n=6
Req 4 - navto 281ms (± 2.41%) 279ms (± 0.75%) ~ 276ms 281ms p=0.936 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 84ms (± 2.24%) 82ms (± 4.43%) ~ 76ms 85ms p=0.558 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,647ms (± 0.75%) 2,656ms (± 0.55%) ~ 2,637ms 2,673ms p=0.378 n=6
Req 2 - geterr 4,346ms (± 0.26%) 4,348ms (± 0.33%) ~ 4,322ms 4,364ms p=0.630 n=6
Req 3 - references 365ms (± 0.77%) 364ms (± 1.24%) ~ 357ms 370ms p=0.746 n=6
Req 4 - navto 288ms (± 1.17%) 288ms (± 1.29%) ~ 283ms 293ms p=0.806 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 73ms (± 1.50%) 73ms (± 1.34%) ~ 72ms 75ms p=0.718 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,326ms (± 0.61%) 3,324ms (± 0.36%) ~ 3,310ms 3,339ms p=0.748 n=6
Req 2 - geterr 1,897ms (± 4.71%) 1,840ms (± 5.82%) ~ 1,753ms 1,985ms p=0.298 n=6
Req 3 - references 110ms (± 1.21%) 110ms (± 1.88%) ~ 107ms 113ms p=0.743 n=6
Req 4 - navto 344ms (± 1.31%) 343ms (± 1.19%) ~ 338ms 348ms p=0.935 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 433ms (± 1.12%) 433ms (± 0.77%) ~ 430ms 438ms p=0.936 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,575ms (± 0.28%) 2,576ms (± 0.54%) ~ 2,553ms 2,595ms p=0.572 n=6
Req 2 - geterr 6,032ms (± 0.62%) 6,014ms (± 0.45%) ~ 5,966ms 6,038ms p=0.423 n=6
Req 3 - references 368ms (± 1.52%) 364ms (± 0.22%) ~ 363ms 365ms p=0.683 n=6
Req 4 - navto 277ms (± 1.40%) 278ms (± 1.34%) ~ 275ms 285ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 100ms (± 2.45%) 100ms (± 2.40%) ~ 95ms 101ms p=0.673 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,796ms (± 0.19%) 2,791ms (± 0.85%) ~ 2,753ms 2,816ms p=0.936 n=6
Req 2 - geterr 4,484ms (± 2.84%) 4,436ms (± 1.79%) ~ 4,394ms 4,598ms p=0.470 n=6
Req 3 - references 379ms (± 0.83%) 379ms (± 0.60%) ~ 375ms 381ms p=0.934 n=6
Req 4 - navto 294ms (± 0.87%) 294ms (± 1.23%) ~ 289ms 298ms p=0.743 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 90ms (±10.44%) 93ms (±10.81%) ~ 83ms 102ms p=0.739 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,651ms (± 0.33%) 3,642ms (± 0.43%) ~ 3,623ms 3,668ms p=0.296 n=6
Req 2 - geterr 1,798ms (± 0.84%) 1,800ms (± 0.70%) ~ 1,784ms 1,814ms p=0.872 n=6
Req 3 - references 128ms (± 3.46%) 128ms (± 1.68%) ~ 124ms 130ms p=0.624 n=6
Req 4 - navto 372ms (± 1.74%) 373ms (± 1.23%) ~ 365ms 379ms p=0.872 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 451ms (± 1.81%) 456ms (± 2.17%) ~ 448ms 473ms p=0.630 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52906 6
Baseline main 6

Startup

Comparison Report - main..52906
Metric main 52906 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.63ms (± 0.21%) 142.24ms (± 0.18%) -0.38ms (- 0.27%) 141.54ms 145.60ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 226.76ms (± 0.15%) 226.38ms (± 0.17%) -0.39ms (- 0.17%) 225.36ms 232.03ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 228.79ms (± 0.14%) 228.27ms (± 0.15%) -0.53ms (- 0.23%) 227.37ms 233.79ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 209.75ms (± 0.15%) 209.12ms (± 0.19%) -0.63ms (- 0.30%) 208.38ms 216.49ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52906 6
Baseline main 6

Developer Information:

Download Benchmark

DanielRosenwasser
DanielRosenwasser reviewed Feb 22, 2023
View reviewed changes
src/compiler/utilities.ts
@@ -596,7 +596,9 @@ export function isTransientSymbol(symbol: Symbol): symbol is TransientSymbol {
const stringWriter = createSingleLineStringWriter();

function createSingleLineStringWriter(): EmitTextWriter {
let str = "";
/* eslint-disable no-var */
var str = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is funny.

@jakebailey jakebailey merged commit b39f10f into microsoft:main Feb 22, 2023
@jakebailey jakebailey deleted the let-const-emitter branch February 22, 2023 19:45
@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakebailey @typescript-bot @DanielRosenwasser