Code

Enable strictFunctionTypes#49929

Code

Merged

jakebailey merged 112 commits intomicrosoft:mainmicrosoft/TypeScript:mainfrom jakebailey:enable-strict-function-typesjakebailey/TypeScript:enable-strict-function-typesCopy head branch name to clipboardJan 18, 2023

+1,257-863

Commits

Commits on Sep 17, 2022

• Fix some easy SFT problems

  jakebailey

  committed
  cd19de3

  Copy full SHA for cd19de3

• More SFT work

  jakebailey

  committed
  666fcf8

  Copy full SHA for 666fcf8

• More fixes

  jakebailey

  committed
  9e58a39

  Copy full SHA for 9e58a39

• Fix emitter, checker

  jakebailey

  committed
  77be346

  Copy full SHA for 77be346

• Fix some more node problems

  jakebailey

  committed
  7061fdb

  Copy full SHA for 7061fdb

• Parser tweaks

  jakebailey

  committed
  82bf75b

  Copy full SHA for 82bf75b

• Resolve TODO

  jakebailey

  committed
  41c4a62

  Copy full SHA for 41c4a62

• More fixes

  jakebailey

  committed
  8bc26db

  Copy full SHA for 8bc26db

• Fix es2015

  jakebailey

  committed
  f985655

  Copy full SHA for f985655

• Fix all except visitNodes problems

  jakebailey

  committed
  79740c8

  Copy full SHA for 79740c8

• Cast to fix type guard arrow function problem

  jakebailey

  committed
  61fbef4

  Copy full SHA for 61fbef4

Commits on Sep 18, 2022

• Completely overhaul node visitor stuff, untested

  jakebailey

  committed
  1b3bd51

  Copy full SHA for 1b3bd51

• Make non-API tests pass without SFT, found some bugs

  jakebailey

  committed
  9d3b851

  Copy full SHA for 9d3b851

Commits on Sep 19, 2022

• Wacky Visitor types

  jakebailey

  committed
  8bcad61

  Copy full SHA for 8bcad61

• It compiles

  jakebailey

  committed
  f2e34f1

  Copy full SHA for f2e34f1

• Write some jsdoc, update baselines

  jakebailey

  committed
  e88bc11

  Copy full SHA for e88bc11

• Fix lint

  jakebailey

  committed
  c31d0a6

  Copy full SHA for c31d0a6

• Actually fix lint

  jakebailey

  committed
  5df975b

  Copy full SHA for 5df975b

• PR feedback

  jakebailey

  committed
  b114cea

  Copy full SHA for b114cea

• Allow non-guards as test parameter

  jakebailey

  committed
  88034eb

  Copy full SHA for 88034eb

• Actually, maybe this does fix Transform

  jakebailey

  committed
  fcda16e

  Copy full SHA for fcda16e

• Update baselines

  jakebailey

  committed
  e7cf213

  Copy full SHA for e7cf213

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  186749e

  Copy full SHA for 186749e

• Update comment

  jakebailey

  committed
  2ed2e92

  Copy full SHA for 2ed2e92

Commits on Sep 20, 2022

• Resolve a TODO

  jakebailey

  committed
  9ae68fd

  Copy full SHA for 9ae68fd

• Remove already resolved TODO

  jakebailey

  committed
  8b1efc1

  Copy full SHA for 8b1efc1

• More todo updats

  jakebailey

  committed
  eff9485

  Copy full SHA for eff9485

• Fix my lint oops

  jakebailey

  committed
  3a5d135

  Copy full SHA for 3a5d135

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  5a609b9

  Copy full SHA for 5a609b9

Commits on Sep 21, 2022

• Much improved NodeVisitor and NodesVisitor

  jakebailey

  committed
  59a3189

  Copy full SHA for 59a3189

• Resolve some TODOs

  jakebailey

  committed
  5bf42fa

  Copy full SHA for 5bf42fa

• Tweaks

  jakebailey

  committed
  00a0f3e

  Copy full SHA for 00a0f3e

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  c053b89

  Copy full SHA for c053b89

Commits on Sep 22, 2022

• Remove TVisited for nodesVisitor

  jakebailey

  committed
  693b9f0

  Copy full SHA for 693b9f0

• Copy rules to visit functions

  jakebailey

  committed
  0d94fe0

  Copy full SHA for 0d94fe0

• Fixups

  jakebailey

  committed
  9876a57

  Copy full SHA for 9876a57

• Simplify other implementations of NodeVisitor and NodesVisitor, now that the type is simpler

  jakebailey

  committed
  721ed63

  Copy full SHA for 721ed63

• Restore undefined-ness of original Visitor type

  jakebailey

  committed
  4329b73

  Copy full SHA for 4329b73

• Make fixes more consistent

  jakebailey

  committed
  45c2ca8

  Copy full SHA for 45c2ca8

• Lint fix

  jakebailey

  committed
  d1a95df

  Copy full SHA for d1a95df

• Address some TODOs

  jakebailey

  committed
  65ad1d3

  Copy full SHA for 65ad1d3

• Shift around TODO

  jakebailey

  committed
  7a4a2c2

  Copy full SHA for 7a4a2c2

• Add a clarifying JSDoc comment to isParameterDeclaration

  jakebailey

  committed
  52ca3a6

  Copy full SHA for 52ca3a6

• Cleanups and reverts

  jakebailey

  committed
  a0af83b

  Copy full SHA for a0af83b

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  bfee29b

  Copy full SHA for bfee29b

• Move the undefined into the VisitResult

  jakebailey

  committed
  d263e9b

  Copy full SHA for d263e9b

• Resolve a TODO

  jakebailey

  committed
  982c706

  Copy full SHA for 982c706

• Change the other VisitResult uses for consistency

  jakebailey

  committed
  fce72fe

  Copy full SHA for fce72fe

• Cleanups

  jakebailey

  committed
  cd4aa3c

  Copy full SHA for cd4aa3c

• Eliminate isArrayOf

  jakebailey

  committed
  734c58f

  Copy full SHA for 734c58f

• Remove cast for byteLength by using BufferEncoding type

  jakebailey

  committed
  1b7fbeb

  Copy full SHA for 1b7fbeb

• Remove checks

  jakebailey

  committed
  a4874b1

  Copy full SHA for a4874b1

• Resolve some TODOs

  jakebailey

  committed
  d3c8231

  Copy full SHA for d3c8231

• Fix lint

  jakebailey

  committed
  76ca962

  Copy full SHA for 76ca962

Commits on Sep 24, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  8fae2ca

  Copy full SHA for 8fae2ca

Commits on Sep 26, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  8f4f9ee

  Copy full SHA for 8f4f9ee

• Mark new helper as internal

  jakebailey

  committed
  b95dc38

  Copy full SHA for b95dc38

Commits on Oct 1, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  65cf0f8

  Copy full SHA for 65cf0f8

Commits on Oct 20, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  29da028

  Copy full SHA for 29da028

• Duplicate jsdoc

  jakebailey

  committed
  46a5d91

  Copy full SHA for 46a5d91

• Accept baselines

  jakebailey

  committed
  f89c0c4

  Copy full SHA for f89c0c4

Commits on Oct 27, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  9d81f75

  Copy full SHA for 9d81f75

• Fix recent bug found by SFT

  jakebailey

  committed
  56f36a5

  Copy full SHA for 56f36a5

Commits on Nov 2, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  5061ebb

  Copy full SHA for 5061ebb

Commits on Nov 5, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  9e6837d

  Copy full SHA for 9e6837d

• Fix compiler error

  jakebailey

  committed
  8e8d706

  Copy full SHA for 8e8d706

Commits on Nov 7, 2022

• Remove unused Parent type param

  jakebailey

  committed
  9eb2720

  Copy full SHA for 9eb2720

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  1ba329e

  Copy full SHA for 1ba329e

Commits on Nov 8, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  b5b49ce

  Copy full SHA for b5b49ce

• Fix merge issues

  jakebailey

  committed
  8d17434

  Copy full SHA for 8d17434

Commits on Nov 9, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  edba1cc

  Copy full SHA for edba1cc

• Fix test

  jakebailey

  committed
  a1c5eca

  Copy full SHA for a1c5eca

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  5f595b7

  Copy full SHA for 5f595b7

• Fix merge

  jakebailey

  committed
  1accebd

  Copy full SHA for 1accebd

Commits on Nov 11, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  7d14f62

  Copy full SHA for 7d14f62

Commits on Nov 15, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  a464d1f

  Copy full SHA for a464d1f

• Fix old merge oops

  jakebailey

  committed
  096bf30

  Copy full SHA for 096bf30

Commits on Nov 16, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  97cad23

  Copy full SHA for 97cad23

• Fix spacing problems caused by merge oops

  jakebailey

  committed
  a401217

  Copy full SHA for a401217

Commits on Nov 17, 2022

• Drop some new calls to Debug.type

  jakebailey

  committed
  ba87ccf

  Copy full SHA for ba87ccf

• Remove my leftover comment

  jakebailey

  committed
  2f192b9

  Copy full SHA for 2f192b9

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  a8608d6

  Copy full SHA for a8608d6

• Fix formatting and export oops

  jakebailey

  committed
  e0dcfb1

  Copy full SHA for e0dcfb1

• More PR fixups

  jakebailey

  committed
  e52a85a

  Copy full SHA for e52a85a

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  78459ba

  Copy full SHA for 78459ba

• fix missed lint

  jakebailey

  committed
  5b54712

  Copy full SHA for 5b54712

• Fix dts

  jakebailey

  committed
  2bb1554

  Copy full SHA for 2bb1554

• Restore old transformer signatures

  jakebailey

  committed
  e14a8a6

  Copy full SHA for e14a8a6

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  6e9ef92

  Copy full SHA for 6e9ef92

• Fix post merge

  jakebailey

  committed
  cd58e0f

  Copy full SHA for cd58e0f

Commits on Dec 6, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  10393c8

  Copy full SHA for 10393c8

• Fix bad merge

  jakebailey

  committed
  2a1c1f1

  Copy full SHA for 2a1c1f1

Commits on Dec 13, 2022

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  75b300e

  Copy full SHA for 75b300e

Commits on Dec 18, 2022

• Restore old cast and tryCast

  jakebailey

  committed
  71d3eac

  Copy full SHA for 71d3eac

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  0c38a85

  Copy full SHA for 0c38a85

• Fix new error

  jakebailey

  committed
  828abf2

  Copy full SHA for 828abf2

Commits on Jan 4, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  9ee1691

  Copy full SHA for 9ee1691

Commits on Jan 5, 2023

• Eagerly test visited nodes during visitArray

  jakebailey

  committed
  cd92e04

  Copy full SHA for cd92e04

Commits on Jan 8, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  e7fa691

  Copy full SHA for e7fa691

• Remove parameters fixed by future LKG

  jakebailey

  committed
  a6f6ebb

  Copy full SHA for a6f6ebb

• Remove assertNode params

  jakebailey

  committed
  e446399

  Copy full SHA for e446399

• Attempt to revert some changes in deprecatedcompat

  jakebailey

  committed
  a0199a3

  Copy full SHA for a0199a3

Commits on Jan 9, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  5e01002

  Copy full SHA for 5e01002

Commits on Jan 10, 2023

• For now, just fully specify all every/some in this file

  jakebailey

  committed
  41cb1fc

  Copy full SHA for 41cb1fc

• Fix typo

  jakebailey

  committed
  ae4be6b

  Copy full SHA for ae4be6b

Commits on Jan 11, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  bfb1417

  Copy full SHA for bfb1417

• Revert some explicit type parameters fixed by inference tweak PRs in main

  jakebailey

  committed
  00261cb

  Copy full SHA for 00261cb

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  268670f

  Copy full SHA for 268670f

Commits on Jan 13, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  129a69e

  Copy full SHA for 129a69e

• Make visitor required in API

  jakebailey

  committed
  837c3d5

  Copy full SHA for 837c3d5

• meh, just remove the check, it's easy to re-add if someone crashes

  jakebailey

  committed
  4ff34cb

  Copy full SHA for 4ff34cb

Commits on Jan 18, 2023

• Merge branch 'main' into enable-strict-function-types

  jakebailey

  committed
  292413f

  Copy full SHA for 292413f