Use changeCompilerHostLikeToUseCache in synchronizeHostData #48980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g caching at that layer
typescript-bot
added
Author: Team
For Uncommitted Bug
sheetalkamat
requested changes
May 6, 2022
src/services/services.ts
Outdated
Comment on lines
1383
to
1389
| cachingInEffect = false; | ||
| compilerHost.getSourceFile = originalGetSourceFile; | ||
| compilerHost.readFile = originalReadFile; | ||
| compilerHost.fileExists = originalFileExists; | ||
| compilerHost.directoryExists = originalDirectoryExists; | ||
| compilerHost.createDirectory = originalCreateDirectory; | ||
| compilerHost.writeFile = originalWriteFile!; |
There was a problem hiding this comment.
Instead of having flag to see if caching is in effect, can we set compilerHost to undefined here and check that instead of flag to see if caching is in effect.
Suggested change
| cachingInEffect = false; | |
| compilerHost.getSourceFile = originalGetSourceFile; | |
| compilerHost.readFile = originalReadFile; | |
| compilerHost.fileExists = originalFileExists; | |
| compilerHost.directoryExists = originalDirectoryExists; | |
| compilerHost.createDirectory = originalCreateDirectory; | |
| compilerHost.writeFile = originalWriteFile!; | |
| compilerHost = undefined; |
There was a problem hiding this comment.
Oops, missed this comment. I'm happy to give that a shot, but I found it pretty difficult to track the lifetime of compilerHost so I'm basically just taking your word for it.
There was a problem hiding this comment.
Done, though I personally prefer the version without the extra bangs.
sheetalkamat
approved these changes
May 17, 2022
|
@amcasey this seems to have broken the twoslash runner—does this stack trace give you any clue as to how/why? |
|
@andrewbranch What's twoslash and is that stack from the product code or from a tool? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than the older, less thorough,
HostCache. The main benefit is caching file and directory existence (and, especially, non-existence) which cuts mui project load time by 1-2% on my (Linux) box.Alternative to #48942