-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Add ES2022 Intl.Segmenter
type
#48800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES2022 Intl.Segmenter
type
#48800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nit, but it looks like every other lib d.ts
file is formatted with four spaces, the standard we use in this repo, while the file added here uses two.
Taking a looking at the MDN article for this, the locale is optional, meaning the first argument may be an object containing options for the segmenter. |
The syntax section implies that you have to provide If you pass an options object as the first parameter, the Segmenter you get back doesn't work properly, so I don't think that's correct (even if it doesn't crash). Try deleting |
I did weigh up the syntax section when writing that comment. Thank you for clarifying my understanding of this. I really appreciate it. |
Fixes #48523