fix(48556): never cannot be spread into object, but it can be spread into JSX props #48570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
I think this is right, but while I'm looking at it, it's kind of strange that object literals return errorType whereas JSX literals try to build up typeToIntersect as a place to hold non-spreadable types. I would think that both kinds of literals would behave the same.
Jack-Works
pushed a commit
to Jack-Works/TypeScript
that referenced
this pull request
Apr 22, 2022
DanielRosenwasser
added
the
Breaking Change
|
This breaks spreading
In JSX spreads. |
Jessidhia
reviewed
May 13, 2022
|
Can you still spread a nullable object onto JSX/objects? |
|
I believe so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48556