Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark length of readonly tuple as readonly #47717

Merged
merged 1 commit into from
Feb 15, 2022
Merged

mark length of readonly tuple as readonly #47717

merged 1 commit into from
Feb 15, 2022

Conversation

Zzzen
Copy link
Contributor

@Zzzen Zzzen commented Feb 3, 2022

Fixes #47260

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 3, 2022
@DanielRosenwasser
Copy link
Member

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 4, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at e1fe677. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 4, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at e1fe677. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 4, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at e1fe677. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 4, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at e1fe677. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 4, 2022 •
edited

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at e1fe677. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/119235/artifacts?artifactName=tgz&fileId=179E3F3899E84A167CD34B8FFD7EC9D18C5D6329A819889FC7558DEC8B922CD902&fileName=/typescript-4.6.0-insiders.20220204.tgz"
    }
}

and then running npm install.

@typescript-bot
Copy link
Collaborator

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..47717

Metric main 47717 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 356,326k (± 0.02%) 356,370k (± 0.01%) +45k (+ 0.01%) 356,225k 356,455k
Parse Time 1.96s (± 0.54%) 1.96s (± 0.65%) +0.00s (+ 0.10%) 1.93s 1.99s
Bind Time 0.85s (± 0.70%) 0.87s (± 0.57%) +0.01s (+ 1.29%) 0.86s 0.88s
Check Time 5.62s (± 0.54%) 5.63s (± 0.61%) +0.02s (+ 0.28%) 5.57s 5.70s
Emit Time 5.91s (± 0.51%) 5.96s (± 0.56%) +0.05s (+ 0.85%) 5.90s 6.04s
Total Time 14.33s (± 0.36%) 14.41s (± 0.41%) +0.08s (+ 0.57%) 14.29s 14.55s
Compiler-Unions - node (v10.16.3, x64)
Memory used 204,231k (± 0.03%) 204,275k (± 0.03%) +44k (+ 0.02%) 204,144k 204,382k
Parse Time 0.79s (± 0.76%) 0.80s (± 1.12%) +0.01s (+ 1.15%) 0.78s 0.82s
Bind Time 0.53s (± 1.30%) 0.53s (± 1.05%) +0.00s (+ 0.57%) 0.52s 0.54s
Check Time 7.87s (± 0.52%) 7.93s (± 0.99%) +0.06s (+ 0.77%) 7.80s 8.17s
Emit Time 2.48s (± 0.85%) 2.47s (± 1.18%) -0.01s (- 0.24%) 2.43s 2.54s
Total Time 11.65s (± 0.38%) 11.72s (± 0.77%) +0.07s (+ 0.57%) 11.55s 11.92s
Monaco - node (v10.16.3, x64)
Memory used 342,657k (± 0.02%) 342,638k (± 0.03%) -19k (- 0.01%) 342,372k 342,781k
Parse Time 1.48s (± 0.42%) 1.49s (± 0.90%) +0.00s (+ 0.27%) 1.46s 1.52s
Bind Time 0.76s (± 0.79%) 0.76s (± 0.45%) +0.00s (+ 0.26%) 0.75s 0.76s
Check Time 5.55s (± 0.61%) 5.54s (± 0.41%) -0.01s (- 0.14%) 5.50s 5.59s
Emit Time 3.21s (± 0.86%) 3.25s (± 1.08%) +0.04s (+ 1.12%) 3.16s 3.31s
Total Time 11.00s (± 0.32%) 11.03s (± 0.33%) +0.03s (+ 0.29%) 10.95s 11.14s
TFS - node (v10.16.3, x64)
Memory used 305,696k (± 0.02%) 305,797k (± 0.02%) +101k (+ 0.03%) 305,658k 305,910k
Parse Time 1.20s (± 0.51%) 1.21s (± 0.75%) +0.01s (+ 0.67%) 1.19s 1.22s
Bind Time 0.72s (± 0.62%) 0.72s (± 0.95%) -0.01s (- 0.83%) 0.70s 0.73s
Check Time 5.06s (± 0.67%) 5.06s (± 0.56%) +0.00s (+ 0.02%) 5.00s 5.11s
Emit Time 3.40s (± 0.76%) 3.40s (± 1.21%) +0.00s (+ 0.06%) 3.34s 3.53s
Total Time 10.38s (± 0.37%) 10.39s (± 0.58%) +0.01s (+ 0.07%) 10.27s 10.56s
material-ui - node (v10.16.3, x64)
Memory used 471,934k (± 0.01%) 471,885k (± 0.01%) -49k (- 0.01%) 471,804k 472,040k
Parse Time 1.78s (± 0.53%) 1.78s (± 0.56%) +0.01s (+ 0.39%) 1.77s 1.81s
Bind Time 0.66s (± 1.21%) 0.67s (± 0.70%) +0.01s (+ 1.21%) 0.66s 0.68s
Check Time 14.25s (± 0.66%) 14.39s (± 0.78%) +0.14s (+ 1.01%) 14.14s 14.63s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.69s (± 0.61%) 16.84s (± 0.70%) +0.16s (+ 0.95%) 16.59s 17.09s
xstate - node (v10.16.3, x64)
Memory used 570,550k (± 0.02%) 574,080k (± 1.39%) +3,531k (+ 0.62%) 570,313k 606,316k
Parse Time 2.56s (± 0.34%) 2.57s (± 0.44%) +0.01s (+ 0.55%) 2.54s 2.59s
Bind Time 1.01s (± 0.29%) 1.02s (± 0.69%) +0.01s (+ 1.09%) 1.01s 1.04s
Check Time 1.50s (± 0.55%) 1.51s (± 0.72%) +0.01s (+ 1.00%) 1.49s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 4.13%) +0.00s (+ 2.86%) 0.07s 0.08s
Total Time 5.14s (± 0.28%) 5.17s (± 0.36%) +0.03s (+ 0.53%) 5.11s 5.20s
Angular - node (v12.1.0, x64)
Memory used 333,906k (± 0.12%) 333,919k (± 0.09%) +13k (+ 0.00%) 332,747k 334,164k
Parse Time 1.95s (± 0.60%) 1.96s (± 0.74%) +0.01s (+ 0.62%) 1.93s 1.99s
Bind Time 0.84s (± 0.86%) 0.85s (± 1.13%) +0.01s (+ 1.07%) 0.83s 0.87s
Check Time 5.42s (± 0.51%) 5.44s (± 0.56%) +0.02s (+ 0.31%) 5.40s 5.55s
Emit Time 6.14s (± 0.58%) 6.15s (± 0.61%) +0.01s (+ 0.21%) 6.09s 6.28s
Total Time 14.35s (± 0.37%) 14.40s (± 0.44%) +0.05s (+ 0.34%) 14.33s 14.64s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,771k (± 0.04%) 191,769k (± 0.03%) -3k (- 0.00%) 191,621k 191,851k
Parse Time 0.78s (± 0.74%) 0.78s (± 0.79%) +0.00s (+ 0.13%) 0.77s 0.79s
Bind Time 0.54s (± 0.69%) 0.54s (± 0.68%) +0.00s (+ 0.19%) 0.53s 0.54s
Check Time 7.32s (± 0.40%) 7.38s (± 0.72%) +0.06s (+ 0.79%) 7.26s 7.55s
Emit Time 2.48s (± 0.91%) 2.47s (± 0.64%) -0.02s (- 0.76%) 2.44s 2.51s
Total Time 11.12s (± 0.30%) 11.16s (± 0.59%) +0.04s (+ 0.36%) 11.03s 11.36s
Monaco - node (v12.1.0, x64)
Memory used 325,727k (± 0.02%) 325,730k (± 0.03%) +3k (+ 0.00%) 325,427k 325,998k
Parse Time 1.46s (± 0.72%) 1.48s (± 1.07%) +0.01s (+ 0.96%) 1.45s 1.51s
Bind Time 0.74s (± 0.91%) 0.74s (± 0.46%) -0.00s (- 0.13%) 0.74s 0.75s
Check Time 5.44s (± 0.60%) 5.47s (± 0.51%) +0.03s (+ 0.53%) 5.41s 5.53s
Emit Time 3.26s (± 0.95%) 3.29s (± 0.78%) +0.04s (+ 1.20%) 3.22s 3.35s
Total Time 10.90s (± 0.37%) 10.99s (± 0.47%) +0.08s (+ 0.74%) 10.89s 11.08s
TFS - node (v12.1.0, x64)
Memory used 290,444k (± 0.02%) 290,454k (± 0.03%) +10k (+ 0.00%) 290,333k 290,679k
Parse Time 1.21s (± 0.66%) 1.21s (± 0.95%) +0.01s (+ 0.41%) 1.20s 1.25s
Bind Time 0.70s (± 1.23%) 0.70s (± 0.63%) +0.00s (+ 0.00%) 0.69s 0.71s
Check Time 4.99s (± 0.40%) 5.00s (± 0.41%) +0.01s (+ 0.14%) 4.96s 5.04s
Emit Time 3.44s (± 0.47%) 3.43s (± 0.50%) -0.01s (- 0.29%) 3.38s 3.47s
Total Time 10.34s (± 0.22%) 10.34s (± 0.28%) +0.00s (+ 0.04%) 10.28s 10.41s
material-ui - node (v12.1.0, x64)
Memory used 450,679k (± 0.01%) 450,709k (± 0.01%) +29k (+ 0.01%) 450,596k 450,792k
Parse Time 1.78s (± 0.33%) 1.79s (± 0.58%) +0.01s (+ 0.84%) 1.77s 1.82s
Bind Time 0.64s (± 0.53%) 0.64s (± 1.13%) -0.00s (- 0.16%) 0.62s 0.66s
Check Time 12.82s (± 0.75%) 12.84s (± 0.87%) +0.02s (+ 0.16%) 12.69s 13.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.24s (± 0.65%) 15.28s (± 0.76%) +0.04s (+ 0.26%) 15.10s 15.54s
xstate - node (v12.1.0, x64)
Memory used 536,436k (± 0.02%) 539,969k (± 1.44%) +3,532k (+ 0.66%) 536,337k 571,349k
Parse Time 2.51s (± 0.74%) 2.50s (± 0.40%) -0.00s (- 0.04%) 2.48s 2.53s
Bind Time 1.05s (± 0.63%) 1.05s (± 0.71%) -0.00s (- 0.00%) 1.04s 1.07s
Check Time 1.44s (± 0.61%) 1.44s (± 0.77%) +0.00s (+ 0.14%) 1.42s 1.48s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.07s (± 0.34%) 5.08s (± 0.30%) +0.01s (+ 0.14%) 5.04s 5.12s
Angular - node (v14.15.1, x64)
Memory used 332,364k (± 0.00%) 332,353k (± 0.01%) -11k (- 0.00%) 332,261k 332,392k
Parse Time 1.95s (± 0.68%) 1.96s (± 0.77%) +0.01s (+ 0.41%) 1.93s 1.99s
Bind Time 0.89s (± 0.79%) 0.89s (± 0.79%) +0.00s (+ 0.22%) 0.88s 0.91s
Check Time 5.45s (± 0.33%) 5.47s (± 0.47%) +0.03s (+ 0.55%) 5.43s 5.52s
Emit Time 6.20s (± 0.53%) 6.21s (± 0.77%) +0.02s (+ 0.29%) 6.13s 6.33s
Total Time 14.49s (± 0.25%) 14.54s (± 0.50%) +0.05s (+ 0.35%) 14.42s 14.74s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,663k (± 0.57%) 193,229k (± 0.39%) +566k (+ 0.29%) 190,358k 193,697k
Parse Time 0.81s (± 0.64%) 0.81s (± 0.84%) +0.01s (+ 0.62%) 0.80s 0.83s
Bind Time 0.56s (± 0.71%) 0.56s (± 0.84%) +0.00s (+ 0.36%) 0.56s 0.58s
Check Time 7.41s (± 0.53%) 7.52s (± 0.71%) +0.11s (+ 1.48%) 7.43s 7.66s
Emit Time 2.50s (± 1.17%) 2.49s (± 0.50%) -0.01s (- 0.24%) 2.46s 2.52s
Total Time 11.28s (± 0.59%) 11.39s (± 0.50%) +0.12s (+ 1.03%) 11.27s 11.53s
Monaco - node (v14.15.1, x64)
Memory used 324,512k (± 0.00%) 324,522k (± 0.01%) +10k (+ 0.00%) 324,479k 324,562k
Parse Time 1.50s (± 0.50%) 1.52s (± 0.63%) +0.02s (+ 1.40%) 1.50s 1.54s
Bind Time 0.77s (± 0.72%) 0.77s (± 0.72%) 0.00s ( 0.00%) 0.76s 0.78s
Check Time 5.38s (± 0.62%) 5.38s (± 0.40%) +0.00s (+ 0.06%) 5.33s 5.43s
Emit Time 3.30s (± 0.94%) 3.29s (± 0.25%) -0.00s (- 0.06%) 3.27s 3.31s
Total Time 10.94s (± 0.58%) 10.96s (± 0.24%) +0.02s (+ 0.20%) 10.92s 11.03s
TFS - node (v14.15.1, x64)
Memory used 289,218k (± 0.01%) 289,241k (± 0.01%) +23k (+ 0.01%) 289,189k 289,291k
Parse Time 1.23s (± 0.81%) 1.23s (± 0.63%) +0.00s (+ 0.08%) 1.22s 1.25s
Bind Time 0.74s (± 0.78%) 0.74s (± 0.78%) +0.00s (+ 0.41%) 0.73s 0.75s
Check Time 4.98s (± 0.44%) 4.99s (± 0.29%) +0.00s (+ 0.06%) 4.95s 5.02s
Emit Time 3.55s (± 0.73%) 3.56s (± 0.50%) +0.02s (+ 0.42%) 3.51s 3.60s
Total Time 10.50s (± 0.42%) 10.52s (± 0.26%) +0.02s (+ 0.19%) 10.44s 10.59s
material-ui - node (v14.15.1, x64)
Memory used 448,902k (± 0.01%) 448,691k (± 0.07%) -211k (- 0.05%) 447,693k 448,942k
Parse Time 1.84s (± 0.58%) 1.85s (± 0.54%) +0.01s (+ 0.33%) 1.83s 1.88s
Bind Time 0.68s (± 0.73%) 0.69s (± 0.75%) +0.01s (+ 0.88%) 0.68s 0.70s
Check Time 12.96s (± 0.55%) 13.06s (± 0.73%) +0.10s (+ 0.79%) 12.86s 13.35s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.48s (± 0.49%) 15.60s (± 0.62%) +0.11s (+ 0.74%) 15.39s 15.89s
xstate - node (v14.15.1, x64)
Memory used 534,082k (± 0.00%) 534,082k (± 0.00%) -0k (- 0.00%) 534,040k 534,104k
Parse Time 2.56s (± 0.57%) 2.56s (± 0.40%) +0.00s (+ 0.08%) 2.54s 2.58s
Bind Time 1.16s (± 0.48%) 1.17s (± 0.96%) +0.01s (+ 0.60%) 1.15s 1.20s
Check Time 1.48s (± 0.60%) 1.49s (± 0.52%) +0.00s (+ 0.34%) 1.47s 1.50s
Emit Time 0.08s (± 0.00%) 0.08s (± 3.81%) -0.00s (- 2.50%) 0.07s 0.08s
Total Time 5.29s (± 0.26%) 5.30s (± 0.34%) +0.01s (+ 0.28%) 5.26s 5.34s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory6 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 47717 10
Baseline main 10

Developer Information:

Download Benchmark

@typescript-bot typescript-bot mentioned this pull request Feb 4, 2022
Open
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member

@typescript-bot user test this inline

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 15, 2022 •
edited

Heya @sandersn, I've started to run the diff-based community code test suite on this PR at e1fe677. You can monitor the build here.

Update: The results are in!

@sandersn sandersn merged commit 81d1457 into microsoft:main Feb 15, 2022
@DanielRosenwasser DanielRosenwasser added the Breaking Change Would introduce errors in existing code label Feb 15, 2022
@typescript-bot
Copy link
Collaborator

@sandersn
Great news! no new errors were found between main..refs/pull/47717/merge

Enes60
Enes60 reviewed Sep 6, 2022
View reviewed changes
Copy link

@Enes60 Enes60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aşkısı

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enes60 Enes60 Enes60 left review comments

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
Breaking Change Would introduce errors in existing code For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readonly open-ended tuples have writable length property
5 participants
@Zzzen @DanielRosenwasser @typescript-bot @sandersn @Enes60