Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly Omit unspreadable properties from rest type in the generic case #47078

Merged
merged 9 commits into from
Dec 9, 2021
Merged

Explicitly Omit unspreadable properties from rest type in the generic case #47078

merged 9 commits into from
Dec 9, 2021

Commits on Dec 8, 2021

  1. Add test case

    @jakebailey
    jakebailey committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    f532408 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Do not use Omit on this when getting rest type

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d213a4d View commit details
    Browse the repository at this point in the history

  2. Add failing test case for regular type param

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    57a6ef7 View commit details
    Browse the repository at this point in the history

  3. Explicitly omit keys unspreadable in rest

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    db5e9fa View commit details
    Browse the repository at this point in the history

  4. Add tests for method

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    7d0aa5c View commit details
    Browse the repository at this point in the history

  5. Rename test to better reflect result

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    5eb70f8 View commit details
    Browse the repository at this point in the history

  6. Test a setter

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    d45768e View commit details
    Browse the repository at this point in the history

  7. Test all different possibilities

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    f2bb9b7 View commit details
    Browse the repository at this point in the history

  8. Also test protected, given omitting private/protected is correct

    @jakebailey
    jakebailey committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    c6f0f2f View commit details
    Browse the repository at this point in the history