Revert changes to matchFiles/readDirectory made since 4.3 #46787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
amcasey
approved these changes
Nov 11, 2021
src/compiler/sys.ts
Outdated
| @@ -1620,12 +1619,6 @@ namespace ts { | |||
| options = { persistent: true }; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I understand a full revert is safer at this point in the cycle, but it would be nice to keep (or quickly restore) this part of the change.
There was a problem hiding this comment.
Can you review the latest commit and see if this is what you had in mind?
| @@ -182,34 +182,3 @@ describe("unittests:: Public APIs:: getChild* methods on EndOfFileToken with JSD | |||
| assert.equal(endOfFileToken.getChildCount(), 1); | |||
| assert.notEqual(endOfFileToken.getChildAt(0), /*expected*/ undefined); | |||
| }); | |||
|
|
|||
| describe("unittests:: Public APIs:: sys", () => { | |||
There was a problem hiding this comment.
We’ll bring it back when we decide what the correct thing to assert is
|
LGTM |
|
@typescript-bot cherry-pick this to release-4.5 |
|
Heya @andrewbranch, I've started to run the task to cherry-pick this into |
|
Hey @andrewbranch, I've opened #46789 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Nov 11, 2021
Component commits: 931b504 Revert "Fix RWC missing file detection (microsoft#46673)" This reverts commit 4a065f5. afef282 Revert "Pass absolute path to directoryExists (microsoft#46086)" This reverts commit 55b4928. f1a20b3 Revert "Reduce exceptions (microsoft#44710)" This reverts commit c0d5c29. 56842cd Add back system watcher limit
andrewbranch
added a commit
that referenced
this pull request
Nov 11, 2021
Component commits: 931b504 Revert "Fix RWC missing file detection (#46673)" This reverts commit 4a065f5. afef282 Revert "Pass absolute path to directoryExists (#46086)" This reverts commit 55b4928. f1a20b3 Revert "Reduce exceptions (#44710)" This reverts commit c0d5c29. 56842cd Add back system watcher limit Co-authored-by: Andrew Branch <[email protected]>
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
…46787) * Revert "Fix RWC missing file detection (microsoft#46673)" This reverts commit 4a065f5. * Revert "Pass absolute path to directoryExists (microsoft#46086)" This reverts commit 55b4928. * Revert "Reduce exceptions (microsoft#44710)" This reverts commit c0d5c29. * Add back system watcher limit
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #44710, #46086, and #46673.
Fixes #46577.
I have discovered that
ts.matchFiles/ts.sys.readDirectorydoes a lot of extremely confusing things, none of which are documented and some of which are probably bugs, but nobody seemed to notice until we started messing with it, so I’m reverting back to our 4.3 state. I will post my findings of what’s weird even in 4.3 so we can decide if any of it is worth fixing (done: #46788).