Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method signature completions #46370

Merged
merged 39 commits into from
Oct 28, 2021
Merged

Add method signature completions #46370

merged 39 commits into from
Oct 28, 2021

Commits on Sep 13, 2021

  1. prototype creation for method override completion snippet

    @gabritto
    gabritto committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    701c5f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. WIP: start using codefix addNewNodeForMemberSymbol to create method… 

    … decl node
    @gabritto
    gabritto committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    2c84d88 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. update type of addNewNodeForMemberSymbol

    @gabritto
    gabritto committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4d2d476 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. add more tests and support more cases

    @gabritto
    gabritto committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c608a6e View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. add more tests and fix some details

    @gabritto
    gabritto committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    2fa43e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. wip: more fixes and tests

    @gabritto
    gabritto committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    1d04720 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. expose check override modifier in checker

    @gabritto
    gabritto committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    905caad View commit details
    Browse the repository at this point in the history

  2. fix test

    @gabritto
    gabritto committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    8ad4042 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. WIP: add snippet support

    @gabritto
    gabritto committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d20eb68 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. WIP: snippet support on emitter, adding snippets in completions

    @gabritto
    gabritto committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    c81f385 View commit details
    Browse the repository at this point in the history

  2. make add snippets work with overloads (not synced)

    @gabritto
    gabritto committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b124c84 View commit details
    Browse the repository at this point in the history

  3. fix snippet adding

    @gabritto
    gabritto committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    db408cc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. rebase

    @gabritto
    gabritto committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d7809c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. WIP: try to add snippet escaping in emitter

    @gabritto
    gabritto committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    41a3c19 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. support escaping in snippets

    @gabritto
    gabritto committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    69ee9fc View commit details
    Browse the repository at this point in the history

  2. small fixes; fixed tests

    @gabritto
    gabritto committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    c3a64bc View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. more tests and fixes

    @gabritto
    gabritto committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e079f71 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. fix new tests

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    d7c26c4 View commit details
    Browse the repository at this point in the history

  2. fix modifier inheritance for overloads

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    fe4fce8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into gabritto/issue45670

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b8bb27a View commit details
    Browse the repository at this point in the history

  4. merge conflict fixes; remove comments

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    952aac1 View commit details
    Browse the repository at this point in the history

  5. throw error if setOptions is called but not implemented

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    00dc206 View commit details
    Browse the repository at this point in the history

  6. fix newline handling

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    28539b6 View commit details
    Browse the repository at this point in the history

  7. fix weird stuff

    @gabritto
    gabritto committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    01eb2bb View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. fix tests

    @gabritto
    gabritto committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    70ebe86 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. fix more tests

    @gabritto
    gabritto committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    e76c18d View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Fix unbound host.getNewLine

    @andrewbranch
    andrewbranch committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    35c1ea3 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. fix isParameterDeclaration changes

    @gabritto
    gabritto committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a639aef View commit details
    Browse the repository at this point in the history

  2. rename diagnostic to status and remove snippets from public api

    @gabritto
    gabritto committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4571e98 View commit details
    Browse the repository at this point in the history

  3. rename emitter functions + fix indentation

    @gabritto
    gabritto committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3a6b6bf View commit details
    Browse the repository at this point in the history

  4. check completion kind before calling isclasslikemembercompletion

    @gabritto
    gabritto committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    302c0fc View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. fix missing type parameters

    @gabritto
    gabritto committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7bdeaa8 View commit details
    Browse the repository at this point in the history

  2. Revert "fix missing type parameters" 

    This reverts commit 7bdeaa8.
    @gabritto
    gabritto committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    68e5913 View commit details
    Browse the repository at this point in the history

  3. add isAmbient flag to addNewNodeForMemberSymbol

    @gabritto
    gabritto committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    d796043 View commit details
    Browse the repository at this point in the history

  4. add test for abstract overloads

    @gabritto
    gabritto committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f6ea5f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. refactor snippet escaping support

    @gabritto
    gabritto committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    221edac View commit details
    Browse the repository at this point in the history

  2. add user preference flag for enabling class member snippets

    @gabritto
    gabritto committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    8e9cac9 View commit details
    Browse the repository at this point in the history

  3. update API baseline

    @gabritto
    gabritto committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    c5f1166 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. update tabstop order

    @gabritto
    gabritto committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    a2665d8 View commit details
    Browse the repository at this point in the history