Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix main by using '.default' on the new ms release #45910

Merged
merged 4 commits into from
Sep 16, 2021
Merged

Fix main by using '.default' on the new ms release #45910

merged 4 commits into from
Sep 16, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 16, 2021

Fixes main - because we update the lockfile, we now use ms v3 which is re-written in TypeScript but has a different export style.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 16, 2021
@orta
Copy link
Contributor Author

orta commented Sep 16, 2021

should unblock #45905

@orta
Copy link
Contributor Author

orta commented Sep 16, 2021 •
edited
Loading

Hrm, looks like it ships ?. in JS which isn't as backwards compatible as our CI - maybe I should just lock it to v2 instead

@andrewbranch andrewbranch merged commit b250f0c into microsoft:main Sep 16, 2021
@andrewbranch
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@orta orta

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orta @andrewbranch @typescript-bot