Only provide hints for simple literals when 'literals' is specified. #45557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-8
to
-13
| //// foo(/*d*/() => 1); | ||
| //// foo(/*e*/function () { return 1 }); | ||
| //// foo(/*f*/{}); | ||
| //// foo(/*g*/{ a: 1 }); | ||
| //// foo(/*h*/[]); | ||
| //// foo(/*i*/[1]); |
There was a problem hiding this comment.
inlayHintsShouldWork35 covers the all case.
mjbvz
approved these changes
Aug 23, 2021
andrewbranch
approved these changes
Aug 23, 2021
DanielRosenwasser
added a commit
that referenced
this pull request
Aug 23, 2021
…45557) * Only provide hints for simple literals when 'literals' is specified. * Update fourslash tests.
This was referenced Sep 25, 2021
BobobUnicorn
pushed a commit
to BobobUnicorn/TypeScript
that referenced
this pull request
Oct 24, 2021
…icrosoft#45557) * Only provide hints for simple literals when 'literals' is specified. * Update fourslash tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.