Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all SortText entries have the same length #45292

Merged
merged 4 commits into from
Aug 2, 2021
Merged

Ensure all SortText entries have the same length #45292

merged 4 commits into from
Aug 2, 2021

Conversation

DanielRosenwasser
Copy link
Member

Fixes #45288

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 2, 2021
@DanielRosenwasser DanielRosenwasser marked this pull request as ready for review August 2, 2021 21:03
@DanielRosenwasser
Copy link
Member Author

I've pushed some changes that are partially necessary (adding the offset from the first SortTextId instead of the first deprecated), but some that I thought might be nice (use a local const enum for SortTextId, move the offset into that enum).

@DanielRosenwasser DanielRosenwasser merged commit 975aabe into main Aug 2, 2021
@DanielRosenwasser DanielRosenwasser deleted the yayStringComparisons branch August 2, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees

@DanielRosenwasser DanielRosenwasser

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out how to encode sortText (because it means TypeScript deprecated completions show up first)
3 participants
@DanielRosenwasser @andrewbranch @typescript-bot