Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly propagate silentNeverType in intersections #45073

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Properly propagate silentNeverType in intersections #45073

merged 2 commits into from
Jul 16, 2021

Conversation

ahejlsberg
Copy link
Member

Fixes #45041.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jul 16, 2021
@ahejlsberg ahejlsberg requested a review from RyanCavanaugh July 16, 2021 17:44
@ahejlsberg
Copy link
Member Author

@RyanCavanaugh Super safe fix, we be safe to take for 4.4 if we think it is merited.

Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this now; I've seen a few reports I think this might fix

@ahejlsberg ahejlsberg merged commit 193b749 into main Jul 16, 2021
@ahejlsberg ahejlsberg deleted the fix45041 branch July 16, 2021 18:20
@devanshj
Copy link

devanshj commented Jul 16, 2021

Can I have a playground build for this please? (I assume the bot can do that, nightly doesn't seem to have this PR) I want to check the impact on #40439. Thanks!
Edit - nvm nightly now has this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contextual inference not working in "nested" scenarios, inferred type is never
4 participants