Ensure singleton types always compare identical #44565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures the "singleton" types (
any,unknown,string,number,boolean,bigint,symbol,void,undefined,never, andobject) always compare identical when their type kind matches, regardless of type object identity. This in particular ensures that theundefinedused to represent a missing property compares identical to the "regular"undefined.The PR also ensures that
TypeFlags.Booleanis consistently set on any union of the boolean literal valuestrueandfalse. We weren't setting this flag on type alias declarations fortrue | false.Fixes #44388.